Merging to release-5.10: [TT-16055] remove redundant codegen:smart (#7495) (#7497)

### **User description**
[TT-16055] remove redundant codegen:smart (#7495)

<!-- Provide a general summary of your changes in the Title above -->

## Description

Remove redundant `task codgen:smart` from CI, as `task tidy` is already
invoking it.
## Related Issue
https://tyktech.atlassian.net/browse/TT-16055

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why






<!---TykTechnologies/jira-linter starts here-->

### Ticket Details

<details>
<summary>
<a href="https://tyktech.atlassian.net/browse/TT-16055" title="TT-16055"
target="_blank">TT-16055</a>
</summary>

|         |    |
|---------|----|
| Status  | In Code Review |
| Summary | Upgrade golangcilint to v2 on tyk gateway |

Generated at: 2025-10-31 11:23:08

</details>

<!---TykTechnologies/jira-linter ends here-->

[TT-16055]:
https://tyktech.atlassian.net/browse/TT-16055?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


___

### **PR Type**
Enhancement, Documentation


___

### **Description**
- Centralize BASE_BRANCH logic in Taskfile

- Remove duplicate BASE_BRANCH vars from includes

- Document automatic base-branch detection

- Improve CI/lint/codegen branch targeting


___

### Diagram Walkthrough


```mermaid
flowchart LR
  Taskfile["Taskfile.yml (root)"]
  Hooks[".taskfiles/hooks.yml"]
  Lint[".taskfiles/lint.yml"]
  Docs["CONTRIBUTING.md"]

  Taskfile -- "defines auto BASE_BRANCH" --> Hooks
  Taskfile -- "inherited var" --> Lint
  Taskfile -- "documented behavior" --> Docs
```



<details> <summary><h3> File Walkthrough</h3></summary>

<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>hooks.yml</strong><dd><code>Drop redundant BASE_BRANCH
in hooks taskfile</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

.taskfiles/hooks.yml

- Remove local BASE_BRANCH var
- Rely on inherited root Taskfile var


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7497/files#diff-4c8ab53446d9cfd97f77a7242f379e0951db3fcd68b2e5d0d78ed5b3960cd574">+0/-4</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>lint.yml</strong><dd><code>Clean up BASE_BRANCH in lint
taskfile</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; </dd></summary>
<hr>

.taskfiles/lint.yml

- Remove local BASE_BRANCH var
- Keep root var inheritance clean


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7497/files#diff-363848321486b220d237efdc32336314ea3369c113f64fdfbec6a38ea62faf66">+0/-2</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>Taskfile.yml</strong><dd><code>Implement BASE_BRANCH
auto-detection in root Taskfile</code>&nbsp; &nbsp; &nbsp; &nbsp;
</dd></summary>
<hr>

Taskfile.yml

<ul><li>Add robust BASE_BRANCH auto-detection<br> <li> Handle
merge/release-*/* branch pattern<br> <li> Default to master if
unmatched<br> <li> Provide inline documentation comments</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7497/files#diff-cd2d359855d0301ce190f1ec3b4c572ea690c83747f6df61c9340720e3d2425e">+24/-1</a>&nbsp;
&nbsp; </td>

</tr>
</table></td></tr><tr><td><strong>Documentation</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>CONTRIBUTING.md</strong><dd><code>Document base branch
detection and overrides</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

CONTRIBUTING.md

<ul><li>Add BASE_BRANCH configuration section<br> <li> Explain
auto-detection and override<br> <li> Provide usage examples</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7497/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055">+18/-0</a>&nbsp;
&nbsp; </td>

</tr>
</table></td></tr></tr></tbody></table>

</details>

___

Co-authored-by: Jeffy Mathew <jeffy.mathew100@gmail.com>

Author: buger

.taskfiles/hooks.yml

@@ -1,10 +1,6 @@
 ---
 version: "3"
 
-vars:
-  BASE_BRANCH:
-    sh: echo "${BASE_BRANCH:-master}"
-
 tasks:
   # pre-commit: run formatting linters on each commit
   # golangci-lint with --fix handles: go fmt (via gofmt formatter), go vet (via govet linter)

.taskfiles/lint.yml

@@ -4,8 +4,6 @@ version: "3"
 vars:
   root:
     sh: git rev-parse --show-toplevel
-  BASE_BRANCH:
-    sh: echo "${BASE_BRANCH:-master}"
 
 tasks:
   tidy:

CONTRIBUTING.md

@@ -84,5 +84,23 @@ task test:integration    # Runs the tests
 task lint    # Runs linting checks
 ```
 
+#### BASE_BRANCH Configuration
+
+The linting and code generation tasks automatically detect the appropriate base branch for comparison:
+
+- **Default behavior**: Compares against `master` branch
+- **Merge/release branches**: If your branch name follows the pattern `merge/release-X.X/*` (e.g., `merge/release-5.8/feature-name`), tasks will automatically compare against `release-X.X`
+- **Manual override**: Set the `BASE_BRANCH` environment variable to specify a custom base branch
+
+```shell
+# Automatic detection (default)
+task lint              # Uses master for regular branches, release-X.X for merge/release-* branches
+
+# Manual override
+BASE_BRANCH=release-5.8 task lint    # Explicitly compare against release-5.8
+```
+
+This automatic base branch detection ensures that linting and code generation only run on files that have changed compared to the appropriate base branch, and git hooks (pre-commit, pre-push) validate changes against the correct baseline.
+
 ### Geo IP features
 This product utilises GeoLite2 data created by MaxMind, available from [http://www.maxmind.com](http://www.maxmind.com).

Taskfile.yml

@@ -24,8 +24,31 @@ includes:
 
 vars:
   path: ./...
+  # BASE_BRANCH: Determines the base branch for diff-based operations (linting, codegen)
+  # This variable is inherited by all included taskfiles.
+  #
+  # Detection logic:
+  # 1. If BASE_BRANCH env var is set, use it
+  # 2. If current branch follows release bot naming convention (merge/release-X.X/*),
+  #    extract and use the release branch (e.g., merge/release-5.8/foo -> release-5.8)
+  # 3. Otherwise, default to master
+  #
+  # This ensures git hooks and linting compare against the correct baseline branch.
   BASE_BRANCH:
-    sh: echo "${BASE_BRANCH:-master}"
+    sh: |
+      if [ -n "${BASE_BRANCH}" ]; then
+        echo "${BASE_BRANCH}"
+      else
+        current_branch=$(git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "")
+        case "$current_branch" in
+          merge/release-*/*)
+            echo "$current_branch" | sed -n 's|^merge/\(release-[^/]*\)/.*|\1|p'
+            ;;
+          *)
+            echo "master"
+            ;;
+        esac
+      fi
 
 tasks:
   build: