Fix LucidaRecords

Author: Meyn

Tubifarry/Download/Clients/Lucida/LucidaDownloadRequest.cs

@@ -271,9 +271,9 @@ private void InitiateDownload(string url, string primaryToken, string fallbackTo
 
         private async Task<bool> PollForCompletionAsync(string handoffId, string serverName, CancellationToken token)
         {
-            const int baseAttempts = 10;
+            const int baseAttempts = 15;
             int delayMs = 3000;
-            int serviceUnavailableExtensions = 0;
+            int serviceUnavailableExtensions = 1;
             const int maxServiceUnavailableExtensions = 20; // Up to 100 minutes total
 
             await Task.Delay(delayMs * 2, token);

Tubifarry/Download/Clients/YouTube/TrustedSessionHelper.cs

@@ -363,7 +363,7 @@ private static bool IsNodeJsAvailable()
                 catch (Exception ex)
                 {
                     _nodeJsAvailable = false;
-                    _logger.Warn(ex, "Node.js environment is not available for local token generation: {Message}", ex.Message);
+                    _logger.Trace(ex, "Node.js environment is not available for local token generation: {Message}", ex.Message);
                     return false;
                 }
                 finally

Tubifarry/Indexers/Lucida/LucidaIndexerSettings.cs

@@ -47,13 +47,12 @@ public class LucidaIndexerSettings : IIndexerSettings
 
         public LucidaIndexerSettings()
         {
-            BaseUrl = "https://lucida.to";
             CountryCode = "US";
             RequestTimeout = 60;
             _servicePriorities = _defaultPriorities.ToList();
         }
 
-        [FieldDefinition(0, Label = "Base URL", Type = FieldType.Textbox, HelpText = "URL of the Lucida instance")]
+        [FieldDefinition(0, Label = "Base URL", Type = FieldType.Textbox, HelpText = "URL of the Lucida instance", Placeholder = "https://lucida.to")]
         public string BaseUrl { get; set; }
 
         [FieldDefinition(1, Label = "Country Code", Type = FieldType.Textbox, HelpText = "Two-letter country code for service regions separated by ;")]

Tubifarry/Indexers/Lucida/LucidaRecords.cs

@@ -29,28 +29,6 @@ public override void Write(Utf8JsonWriter writer, string value, JsonSerializerOp
         }
     }
 
-    /// <summary>
-    /// Custom JSON converter that handles both string and numeric IDs, converting them to long
-    /// </summary>
-    public class FlexibleLongConverter : JsonConverter<long>
-    {
-        public override long Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-        {
-            return reader.TokenType switch
-            {
-                JsonTokenType.Number => reader.GetInt64(),
-                JsonTokenType.String => long.TryParse(reader.GetString(), out long result) ? result :
-                    throw new JsonException($"Cannot convert string '{reader.GetString()}' to long"),
-                _ => throw new JsonException($"Cannot convert token type {reader.TokenType} to long")
-            };
-        }
-
-        public override void Write(Utf8JsonWriter writer, long value, JsonSerializerOptions options)
-        {
-            writer.WriteNumberValue(value);
-        }
-    }
-
     /// <summary>
     /// Custom JSON converter for flexible float handling
     /// </summary>
@@ -242,7 +220,7 @@ public CountryResponse() : this(false) { }
     public record LucidaInfo(
         [property: JsonPropertyName("success")] bool Success,
         [property: JsonPropertyName("type")] string Type = "",
-        [property: JsonPropertyName("id"), JsonConverter(typeof(FlexibleLongConverter))] long Id = 0,
+        [property: JsonPropertyName("id"), JsonConverter(typeof(FlexibleStringConverter))] string Id = "",
         [property: JsonPropertyName("url")] string Url = "",
         [property: JsonPropertyName("title")] string Title = "",
         [property: JsonPropertyName("durationMs")] long DurationMs = 0,
@@ -305,23 +283,21 @@ public record LucidaArtworkInfo(
     /// Album reference within track info
     /// </summary>
     public record LucidaAlbumRef(
-        [property: JsonPropertyName("id"), JsonConverter(typeof(FlexibleLongConverter))] long Id,
+        [property: JsonPropertyName("id"), JsonConverter(typeof(FlexibleStringConverter))] string Id = "",
         [property: JsonPropertyName("url")] string Url = "",
         [property: JsonPropertyName("title")] string Title = "",
         [property: JsonPropertyName("releaseDate")] string? ReleaseDate = null)
     {
         [JsonPropertyName("coverArtwork")]
         public LucidaArtworkInfo[] CoverArtwork { get; init; } = Array.Empty<LucidaArtworkInfo>();
-
-        public LucidaAlbumRef() : this(0) { }
     };
 
     /// <summary>
     /// Track info within album
     /// </summary>
     public record LucidaTrackInfo(
         [property: JsonPropertyName("url")] string Url = "",
-        [property: JsonPropertyName("id"), JsonConverter(typeof(FlexibleLongConverter))] long Id = 0,
+        [property: JsonPropertyName("id"), JsonConverter(typeof(FlexibleStringConverter))] string Id = "",
         [property: JsonPropertyName("title")] string Title = "",
         [property: JsonPropertyName("durationMs")] long DurationMs = 0,
         [property: JsonPropertyName("isrc")] string? Isrc = null,