Error when trying to build Tubifarry

[sn0skier]

I'm trying to build Tubifarry so that I can debug an issue that I posted on this repo. I've followed the contribution.md very closely, but I'm getting an error when I build the actual plugin (lidarr submodule builds fine).
Unable to resolve assembly '..\_plugins\Tubifarry\System.Text.Json.dll'
I've enabled detailed logging in case that helps:
Build Error Log.txt

Please let me know if there's something else you need from me. I've sunk many hours into trying to figure this out and I'm desperate. I really want to debug my own problems, but I need help I guess.

[TypNull]

You're correct, I can reproduce it too. The issue stems from .NET's behavior of not copying framework DLLs. Since the YouTube generator requires a newer version of System.Text.Json, we need to explicitly include it in the ILRepack package.

The reason this error went unnoticed is that when Lidarr updated its libraries, my _plugin folder still retained references from the older version, so the DLL appeared to be present. However, it's no longer being copied to the output directory.
The Solution to it is:
In Tubifarry\ILRepack.targets, replace this line:

<InputAssemblies Include="$(OutputPath)System.Text.Json.dll" />

With:

<InputAssemblies Include="..\Submodules\Lidarr\_output\net8.0\System.Text.Json.dll" />

This ensures ILRepack references the correct version of System.Text.Json from Lidarr's output directory.

[sn0skier]

Hi, thanks for the quick response.

I'm now getting a different error Unable to resolve assembly '..\Submodules\Lidarr\_output\net8.0\System.Text.Json.dll' because I don't have \Submodules\Lidarr\_output\net8.0\System.Text.Json.dll. Maybe it's a similar issue of a leftover DLL?

[TypNull]

In my tests, Lidarr exports the dll correctly:

You still have other options to resolve the issue. For example you can manually download the DLL:

1. Download the package from NuGet Download.
2. Rename the file extension to .zip and extract it.
3. Navigate to lib/net8.0 and copy the System.Text.Json.dll file to your _plugin/Tubifarry/ directory.
   Make sure to revert to:

<InputAssemblies Include="$(OutputPath)System.Text.Json.dll" />

[sn0skier]

So I removed <InputAssemblies Include="$(OutputPath)System.Text.Json.dll" /> entirely and downgraded

		<PackageReference Include="Xabe.FFmpeg" Version="5.2.6" />
		<PackageReference Include="Xabe.FFmpeg.Downloader" Version="5.2.6" />

inside Tubifarry.csproj as they required System.Text.Json 9.0.0.0 while everything else required System.Text.Json 8.0.0.0

Everything compiles. Does everything work though? That's something I don't know how to answer. And honestly I only figured out the above with substantial help from a chatbot.

[TypNull]

Xabe.FFmpeg works fine with the older version. However, it might include outdated FFmpeg builds that could have unpatched vulnerabilities. While this isn’t urgent, I’d still recommend updating Xabe.FFmpeg when you feel like it.
I assumed the YouTube generator is using the v9 Json.dll, but it seems I was wrong. Fortunately, the different versions are quite compatible with each other, so I just forced Xabe to use the same version as Lidarr.