fix: Unexpected getSelection (#1030)

* fix: Unexpected getSelection

* clear

* Updated test

* Fixed tests

---------

Co-authored-by: matthewlipski <[email protected]>

Author: jkcs

packages/core/src/editor/BlockNoteEditor.ts

@@ -724,9 +724,16 @@ export class BlockNoteEditor<
         return true;
       }
 
+      // Fixed the block pos and size
+      // all block is wrapped with a blockContent wrapper
+      // and blockContent wrapper pos = inner block pos - 1
+      // blockContent wrapper end = inner block pos + nodeSize + 1
+      // need to add 1 to start and -1 to end
+      const end = pos + node.nodeSize - 1;
+      const start = pos + 1;
       if (
-        pos + node.nodeSize < this._tiptapEditor.state.selection.from ||
-        pos > this._tiptapEditor.state.selection.to
+        end <= this._tiptapEditor.state.selection.from ||
+        start >= this._tiptapEditor.state.selection.to
       ) {
         return true;
       }

tests/src/end-to-end/textalignment/textAlignment.test.ts

@@ -21,7 +21,7 @@ test.describe("Check Text Alignment Functionality", () => {
     await page.keyboard.press("ArrowUp");
     await page.keyboard.press("ArrowUp");
     await page.keyboard.press("Control+ArrowLeft");
-    await page.keyboard.press("Control+Shift+ArrowRight");
+    await page.keyboard.press("Control+Shift+ArrowDown");
 
     await page.locator(ALIGN_TEXT_RIGHT_BUTTON_SELECTOR).click();
     await page.waitForTimeout(350);
@@ -42,10 +42,12 @@ test.describe("Check Text Alignment Functionality", () => {
     await insertHeading(page, 2);
     await insertHeading(page, 3);
 
+    await page.keyboard.press("ArrowUp");
     await page.keyboard.press("ArrowUp");
     await page.keyboard.press("ArrowUp");
     await page.keyboard.press("Control+ArrowLeft");
-    await page.keyboard.press("Control+Shift+ArrowUp");
+    await page.keyboard.press("Control+Shift+ArrowDown");
+    await page.keyboard.press("Control+Shift+ArrowDown");
 
     await page.locator(ALIGN_TEXT_RIGHT_BUTTON_SELECTOR).click();
     await page.waitForTimeout(350);
@@ -54,6 +56,7 @@ test.describe("Check Text Alignment Functionality", () => {
     // Waits for formatting toolbar animation to finish.
     await page.waitForTimeout(500);
     await page.keyboard.press("ArrowLeft");
+    await page.pause();
 
     expect(await page.screenshot()).toMatchSnapshot(
       "alignTextMultipleBlocks.png"