Skip to content
This repository was archived by the owner on Aug 14, 2021. It is now read-only.

Commit 375f8b4

Browse files
committed
fix: Better handling for getters/setters in object literals
Resolves TypeStrong/typedoc#1475
1 parent 9fa0243 commit 375f8b4

File tree

1 file changed

+52
-40
lines changed

1 file changed

+52
-40
lines changed

src/default/partials/parameter.hbs

+52-40
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
</li>
4040
{{/if}}
4141
{{#each children}}
42-
<li class="tsd-parameter">
43-
{{#if signatures}}
42+
{{#if signatures}}
43+
<li class="tsd-parameter">
4444
<h5>{{#compact}}
4545
{{#if flags.isRest}}<span class="tsd-signature-symbol">...</span>{{/if}}
4646
{{{wbr name}}}
@@ -52,7 +52,9 @@
5252
{{/compact}}</h5>
5353

5454
{{> member.signatures}}
55-
{{else}}
55+
</li>
56+
{{else}}{{#if type}} {{! standard type }}
57+
<li class="tsd-parameter">
5658
<h5>{{#compact}}
5759
{{#each flags}}
5860
<span class="tsd-flag ts-flag{{this}}">{{this}}</span>&nbsp;
@@ -65,41 +67,6 @@
6567
:&nbsp;
6668
</span>
6769
{{>type}}
68-
{{else}}
69-
{{#if getSignature}}
70-
{{#if setSignature}}
71-
{{{wbr name}}}
72-
<span class="tsd-signature-symbol">:&nbsp;</span>
73-
{{#with getSignature.type}}
74-
{{> type}}
75-
{{/with}}
76-
{{else}}
77-
<span class="tsd-signature-symbol">get&nbsp;</span>
78-
{{{wbr name}}}
79-
<span class="tsd-signature-symbol">():&nbsp;</span>
80-
{{#with getSignature.type}}
81-
{{> type}}
82-
{{/with}}
83-
{{/if}}
84-
{{else}}
85-
{{#if setSignature}}
86-
<span class="tsd-signature-symbol">set&nbsp;</span>
87-
{{{wbr name}}}
88-
<span class="tsd-signature-symbol">(</span>
89-
{{#each setSignature.parameters}}
90-
{{name}}
91-
<span class="tsd-signature-symbol">: </span>
92-
{{#with type}}
93-
{{> type}}
94-
{{else}}
95-
<span class="tsd-signature-type">any</span>
96-
{{/with}}
97-
{{/each}}
98-
<span class="tsd-signature-symbol">)</span>
99-
{{else}}
100-
<span class="tsd-signature-type">any</span>
101-
{{/if}}
102-
{{/if}}
10370
{{/with}}
10471
{{/compact}}</h5>
10572

@@ -114,7 +81,52 @@
11481
{{> parameter}}
11582
{{/with}}
11683
{{/if}}
117-
{{/if}}
118-
</li>
84+
</li>
85+
{{else}} {{! getter/setter }}
86+
{{#with getSignature}} {{! getter }}
87+
<li class="tsd-parameter">
88+
<h5>{{#compact}}
89+
{{#each flags}}
90+
<span class="tsd-flag ts-flag{{this}}">{{this}}</span>&nbsp;
91+
{{/each}}
92+
<span class="tsd-signature-symbol">get&nbsp;</span>
93+
{{{wbr ../name}}}
94+
<span class="tsd-signature-symbol">():&nbsp;</span>
95+
{{#with type}}
96+
{{> type}}
97+
{{/with}}
98+
{{/compact}}</h5>
99+
100+
{{> comment }}
101+
</li>
102+
{{/with}}
103+
{{#with setSignature}} {{! setter }}
104+
<li class="tsd-parameter">
105+
<h5>{{#compact}}
106+
{{#each flags}}
107+
<span class="tsd-flag ts-flag{{this}}">{{this}}</span>&nbsp;
108+
{{/each}}
109+
<span class="tsd-signature-symbol">set&nbsp;</span>
110+
{{{wbr ../name}}}
111+
<span class="tsd-signature-symbol">(</span>
112+
{{#each parameters}}
113+
{{name}}
114+
<span class="tsd-signature-symbol">: </span>
115+
{{#with type}}
116+
{{> type}}
117+
{{else}}
118+
<span class="tsd-signature-type">any</span>
119+
{{/with}}
120+
{{/each}}
121+
<span class="tsd-signature-symbol">):&nbsp;</span>
122+
{{#with type}}
123+
{{> type}}
124+
{{/with}}
125+
{{/compact}}</h5>
126+
127+
{{> comment }}
128+
</li>
129+
{{/with}}
130+
{{/if}}{{/if}}
119131
{{/each}}
120132
</ul>

0 commit comments

Comments
 (0)