fix(coverage): use sed for html_escape cross-version bash compatibility

Chemaclass · Chemaclass · commit c8313c4745b8 · 2025-12-24T23:19:02.000+01:00
diff --git a/src/coverage.sh b/src/coverage.sh
@@ -728,12 +728,10 @@ function bashunit::coverage::check_threshold() {
 }
 
 # Escape HTML special characters
+# Uses sed for cross-version bash compatibility (bash 3.2 vs 4.4+ handle & differently in replacement strings)
 function bashunit::coverage::html_escape() {
   local text="$1"
-  text="${text//&/&amp;}"
-  text="${text//</&lt;}"
-  text="${text//>/&gt;}"
-  echo "$text"
+  printf "%s" "$text" | sed "s/&/\&amp;/g; s/</\&lt;/g; s/>/\&gt;/g"
 }
 
 # Convert file path to safe filename for HTML

Original file line number	Diff line number	Diff line change
`@@ -728,12 +728,10 @@ function bashunit::coverage::check_threshold() {`
`728`	`728`	`}`
`729`	`729`
`730`	`730`	`# Escape HTML special characters`
	`731`	`+# Uses sed for cross-version bash compatibility (bash 3.2 vs 4.4+ handle & differently in replacement strings)`
`731`	`732`	`function bashunit::coverage::html_escape() {`
`732`	`733`	`local text="$1"`
`733`		`- text="${text//&/&}"`
`734`		`- text="${text//</<}"`
`735`		`- text="${text//>/>}"`
`736`		`- echo "$text"`
	`734`	`+ printf "%s" "$text" \| sed "s/&/\&/g; s/</\</g; s/>/\>/g"`
`737`	`735`	`}`
`738`	`736`
`739`	`737`	`# Convert file path to safe filename for HTML`