Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Code refactoring of the whole project #30

@Incred

Description

@Incred

Came across with the project accidentally (actually use TypeForm API in production (but my own implementation)).
After reading the code, I decided that it should be refactored a little, as I noticed many cases that, in my opinion, need to be rewritten:

  • functions in utils seem to me pretty strange and even a little redundant (e.g. mergeDict: since starting with python 3.9 it's enought to use "|" for dicts union), naming of the functions etc.
  • PEP-8 violations: naming of variables (it is preferable to use lower case with underscores), max line length, docstrings, etc
  • There are unused constants in constants.py. And actually it seems like it's better to name it settings.py instead.
  • string formatting. Much more readable (IMHO) use f-strings there (since python 3.6)

actually already have a commit with all these changes: 7910ba4
So I can make a PR

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions