What happens if the strings in `log_levels` are localized?

[0tkl]

Aegisub/src/preferences.cpp

Lines 461 to 466 in 39f6912

	#ifdef WITH_FFMS2
	auto ffms = p->PageSizer("FFmpegSource");
	const wxString log_levels[] = { _("Quiet"), _("Panic"), _("Fatal"), _("Error"), _("Warning"), _("Info"), _("Verbose"), _("Debug") };
	wxArrayString log_levels_choice(8, log_levels);
	p->OptionChoice(ffms, _("Debug log verbosity"), log_levels_choice, "Provider/FFmpegSource/Log Level");

Aegisub/src/ffmpegsource_common.cpp

Lines 141 to 161 in 39f6912

	void FFmpegSourceProvider::SetLogLevel() {
	auto LogLevel = OPT_GET("Provider/FFmpegSource/Log Level")->GetString();
	boost::to_lower(LogLevel);
	if (LogLevel == "panic")
	FFMS_SetLogLevel(FFMS_LOG_PANIC);
	else if (LogLevel == "fatal")
	FFMS_SetLogLevel(FFMS_LOG_FATAL);
	else if (LogLevel == "error")
	FFMS_SetLogLevel(FFMS_LOG_ERROR);
	else if (LogLevel == "warning")
	FFMS_SetLogLevel(FFMS_LOG_WARNING);
	else if (LogLevel == "info")
	FFMS_SetLogLevel(FFMS_LOG_INFO);
	else if (LogLevel == "verbose")
	FFMS_SetLogLevel(FFMS_LOG_VERBOSE);
	else if (LogLevel == "debug")
	FFMS_SetLogLevel(FFMS_LOG_DEBUG);
	else
	FFMS_SetLogLevel(FFMS_LOG_QUIET);
	}

Could this result in “no matter which option is set, the final effect is always quiet”?

[arch1t3cht]

Indeed, this change was broken. I had the wrong assumption that OptionChoice always resulted in an integer option, but it can actually represent both string and integer options, depending on what type is set in default_config.json.

Still, I don't think it's wrong to make the log options translatable. The translation call just needs to be moved to OptionChoice. I will fix this soon.