fix unit tests

Author: Lmh-java

src/software/ai/hl/stp/tactic/BUILD

@@ -154,6 +154,7 @@ cc_library(
         ":primitive",
         "//proto/message_translation:tbots_protobuf",
         "//software/util/hash:hash_combine",
+        "//software/ai/navigator/obstacle:robot_navigation_obstacle_factory",
     ]
 )
 

src/software/ai/hl/stp/tactic/vis_proto_deduper_test.cpp

@@ -1,24 +1,22 @@
 
 #include "software/ai/hl/stp/tactic/vis_proto_deduper.h"
 #include "software/ai/navigator/obstacle/obstacle.hpp"
+#include "software/ai/navigator/obstacle/robot_navigation_obstacle_factory.h"
 #include "software/geom/polygon.h"
 #include "software/geom/point.h"
 
 #include <gtest/gtest.h>
 #include <memory>
 #include <vector>
 
-// Helper to create a unique obstacle based on a position offset
-// This ensures we have distinct geometries to hash.
-ObstaclePtr createTestObstacle(double x, double y)
-{
-    auto polygon = Polygon({Point(x, y), Point(x + 1.0, y + 1.0), Point(x - 1.0, y - 1.0)});
-    return std::make_shared<Obstacle>(polygon);
-}
+
 
 class VisProtoDeduperTest : public ::testing::Test
 {
 protected:
+    RobotNavigationObstacleFactory obstacle_factory =
+        RobotNavigationObstacleFactory(TbotsProto::RobotNavigationObstacleConfig());
+
     // Helper to extract the list of obstacles from the proto message for easy verification
     std::vector<TbotsProto::Obstacle> getObstaclesFromProto(const TbotsProto::ObstacleList& msg)
     {
@@ -27,7 +25,15 @@ class VisProtoDeduperTest : public ::testing::Test
         {
             obstacles.push_back(obs);
         }
-        return obstacles;
+        return obstacles;;
+    }
+
+    // Helper to create a unique obstacle based on a position offset
+    // This ensures we have distinct geometries to hash.
+    ObstaclePtr createTestObstacle(double x, double y)
+    {
+        auto polygon = Polygon({Point(x, y), Point(x + 1.0, y), Point(x, y + 1.0)});
+        return obstacle_factory.createFromShape(polygon);
     }
 };