📊 Improving Analysis Code

[arc-teaching]

Open the repository for this exercise. You will find a brief description of each example in its README.md file.

1. Discuss the code with your group. What problems do you see with it? Why?
2. Write below your comments mentioning your group number. For now, focus on the
   problems, and don't make any changes yet!

[georgemarklow]

Group 16:

• From math import * should be more specific what functions are actually needed
• Opening files, doing some arithmetic, weights, sum last bit
• Repetition, move the opening and logic into its own method so overall code is shorter, less duplication, easier to read, allows us to unit test the one reusable function
• Lot of for loops
• Variable name “Critical” is unclear
• Workflow 2 has code commented out, and doing the same thing
• Workflow 2 last line is an average, which could be more clearly stated in a variable with a good name
• Comments above with open, jargon code
• CSV files don’t contain column names, just numbers
• CSV file names don’t indicate what it is, just sample1 and sample2 with no context

[zewei0212]

Group 06
Usually for loops will be helpful in reducing the complexity of the code/ algorithm. However if in a code file only exist a single and long loop, that will be a disaster, hard to read.