refactor(FText): Remove FText_Constructor.lua as an override

It's no longer needed because we no longer call the FText constructor directly.

Author: UE4SS

UE4SS/src/Signatures.cpp

@@ -259,52 +259,6 @@ namespace RC
             };
         }
 
-        auto lua_ftc_scan_script = working_directory / "UE4SS_Signatures/FText_Constructor.lua";
-        if (std::filesystem::exists(lua_ftc_scan_script))
-        {
-            config.ScanOverrides.ftext_constructor = [lua_ftc_scan_script](std::vector<SignatureContainer>& signature_containers,
-                                                                           Unreal::Signatures::ScanResult& scan_result) mutable {
-                scan_from_lua_script(
-                        lua_ftc_scan_script,
-                        signature_containers,
-                        [&scan_result](void* address) {
-                            if (!Unreal::GMalloc || !*Unreal::GMalloc)
-                            {
-                                    scan_result.Errors.emplace_back("Lua script 'FText_Constructor.lua' cannot be tried; GMalloc nullptr.");
-                                    return DidLuaScanSucceed::No;
-                            }
-                            Unreal::FText text{};
-                            SEH_TRY({ text = Unreal::FText(STR("bCanBeDamaged"), address); })
-                            SEH_EXCEPT({ Output::send<LogLevel::Error>(STR("Error: Crashed calling FText constructor.\n")); });
-
-                            DidLuaScanSucceed did_succeed{};
-                            SEH_TRY({
-                                if (text == STR("bCanBeDamaged"))
-                                {
-                                    Output::send(STR("FText::FText address: {} <- Lua Script\n"), address);
-                                    Unreal::FText::ConstructorInternal.assign_address(address);
-                                    did_succeed = DidLuaScanSucceed::Yes;
-                                }
-                                else
-                                {
-                                    scan_result.Errors.emplace_back("Lua script 'FText_Constructor.lua' did not return a "
-                                                                    "valid address for FText::FText.");
-                                    did_succeed = DidLuaScanSucceed::No;
-                                }
-                            })
-                            SEH_EXCEPT({ Output::send<LogLevel::Error>(STR("Error: Crashed calling FText::ToString.\n")); })
-                            return did_succeed;
-                        },
-                        [&scan_result]([[maybe_unused]] DidLuaScanSucceed did_lua_scan_succeed) {
-                            if (!Unreal::FText::ConstructorInternal.get_function_address())
-                            {
-                                scan_result.Errors.emplace_back("Lua script 'FText_Constructor.lua' did not return a "
-                                                                "valid address for FText::FText.");
-                            }
-                        });
-            };
-        }
-
         auto lua_guhashtables_scan_script = working_directory / "UE4SS_Signatures/GUObjectHashTables.lua";
         if (std::filesystem::exists(lua_guhashtables_scan_script))
         {

assets/Changelog.md

@@ -311,6 +311,8 @@ Removed some development mods, `README.md` & `Changelog.md` from non-zDev releas
 
 The execution of the game is now paused durin the first AOB scan, and then resumed to complete potential further scans and initialization. ([UE4SS #985](https://github.com/UE4SS-RE/RE-UE4SS/pull/985))
 
+Removed the FText constructor AOB, replaced it with more consistent non-AOB method of constructing FText instances ([UE4SS #1139](https://github.com/UE4SS-RE/RE-UE4SS/pull/1139))
+
 ### Live View 
 Fixed the majority of the lag ([UE4SS #512](https://github.com/UE4SS-RE/RE-UE4SS/pull/512))