Skip rules "no-outdated-manifest-version" and "no-legacy-ui5-version-in-manifest"

[rschristian1]

Hi

Due to our deployment target, we are bound to UI5 v1.108.xx.
Is there a way to suppress rules "no-outdated-manifest-version" and "no-legacy-ui5-version-in-manifest"?
Ideally, by excluding these rules globally in "ui5lint.config.js", since directives are not supported for JSON files (such as manifest.json in my example).

Many thanks
Christian

[flovogt]

Hi @rschristian1, we have already planned such a feature and created a backlog item (CPOUI5FOUNDATION-898). But won't be able to implement this in the next time.

[pwasemsap]

@flovogt is there any update on this yes? We would have the same feature request. I would even argue that this is a crucial feature that is currently missing from the linter.

The problem is that one can often not simply upgrade to the latest (SAP)UI5 version due to system constraints. However, one should still be able to use the linter. Therefore, the requirement would be to be able to disable any rule or configure the severity (off, warning, error).

Thanks in advance.

[flovogt]

@pwasemsap you can use manifest v2 already in UI5 1.136 and later in case you are not aware of this.

I totally get your point. We will work on this but not in the next 3 months.

[qualiture]

@flovogt That is a real pity, given the linter and UI5 documentation seem to contradict; right now, as of 1.136 or higher the linter throws an error, which in itself is fine. However, the documentation at https://ui5.sap.com/#/topic/be0cf40f61184b358b5faedaec98b2da states "[..] As of SAPUI5 1.136, we support the new Manifest Version 2 [..]" which make it seem as an option.

I think it should either be documented as a mandatory version, and then the error status is correct. Or, if it is indeed an option, make it a warning.

As we have the ui5 linter in our pre-commit hook, this now blocks every commit. As a countermeasure I have removed checking the manifest.json file altogether, but this is far from ideal either...

[codeworrior]

UI5 Linter and UI5 1.x documentation both are correct:

• The current goal of the UI5 Linter is to help developers to make their apps future proof, which in our terminology means: the apps can run on 1.x and 2.x.
• In UI5 2.x, a Manifest 2.0.0 or higher is mandatory, that's why the linter must encourage its use (given its current goal setting)
• In UI5 1.136 and higher (but lower than 2.0.0), Manifest 2.0.0 is an option. You can, however, still use a 1.y manifest. But the linter can't report it that way, given its current goals.

As @flovogt mentioned, we plan to improve the UI5 linter and make it capable of targeting UI5 versions other than 2.0.0. But not in the near future.

[rschristian1]

I see that we're having similar issues here. While I'm bound to UI5 v1.108.xx due to our deployment target, even people with higher UI5 versions also wish to exclude these linter rules.
I guess there will always be the need to exclude specific rules from the linter check; everything else would only work in an ideal environment. @flovogt Can you please keep us posted on CPOUI5FOUNDATION-898?
Meanwhile, I'll use @qualiture's workaround. Thank you for this hint.

[flovogt]

Thanks a lot for your feedback @qualiture and @rschristian1. As we receive several similar requests, I will increase the priority for this topic.