Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3036) Remove code related to continuing activities #2339

Closed
wants to merge 1 commit into from

Conversation

CristinaRO
Copy link
Contributor

Changes in this PR

  • Remove the supporting code for the one-off data migration related to the new DSIT transparency identifier (rake task and continuing/non-continuing activities exports)

Screenshots of UI changes

Before

Screenshot 2024-01-15 at 15 58 41

After

The above section is not present.

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

Now that the one-off data migration related to the new DSIT transparency
(IATI) identifier has been done, we need to remove the temporary code
that has enabled the exports and the data changes.
@CristinaRO
Copy link
Contributor Author

Copy link
Collaborator

@shuldt shuldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to go in iff we get sign off from DSIT that we will not need to run this process again :)

@CristinaRO
Copy link
Contributor Author

Dan said "If possible would be useful to keep them for a while. At least the next few months.", so I'm going to close this PR for now. It is still linked from Trello, so we won't lose the existing work.

@CristinaRO CristinaRO closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants