UKVIET-79: Update Feedback Url (#229)

- added ref to env feedback url (config.js)

- set value of feedback url to config value (server.js)

- updated node version in drone (.drone.yml)

- upgraded HOF package and dependencies (yarn.lock)

- removed devDependency funkie-chromedriver (package.json)

Author: tobyschaefferHO

.drone.yml

@@ -25,15 +25,15 @@ trigger:
 
 linting: &linting
   pull: if-not-exists
-  image: node:lts
+  image: node:20
   environment:
     NOTIFY_KEY: USE_MOCK
   commands:
     - yarn run test:lint
 
 unit_tests: &unit_tests
   pull: if-not-exists
-  image: node:lts
+  image: node:20
   environment:
     NOTIFY_KEY: USE_MOCK
   commands:
@@ -67,7 +67,7 @@ steps:
 
   - name: setup_deploy
     pull: if-not-exists
-    image: node:lts
+    image: node:20
     environment:
       NOTIFY_KEY: USE_MOCK
     commands:
@@ -176,7 +176,7 @@ steps:
 
   - name: setup_branch
     pull: if-not-exists
-    image: node:lts
+    image: node:20
     environment:
       NOTIFY_KEY: USE_MOCK
     commands:
@@ -233,7 +233,7 @@ steps:
   # Snyk security scans which run after branch deployment to prevent blocking of PR UAT tests
   - name: snyk_scan
     pull: if-not-exists
-    image: node:lts
+    image: node:20
     environment:
       SNYK_TOKEN:
         from_secret: snyk_token

config.js

@@ -9,6 +9,7 @@ module.exports = {
   DATE_FORMAT: 'YYYY-MM-DD',
   PRETTY_DATE_FORMAT: 'Do MMMM YYYY',
   dateTimeFormat: 'DD MMM YYYY HH:MM:SS ZZ',
+  feedbackUrl: process.env.FEEDBACK_URL,
   notify: {
     apiKey: process.env.NOTIFY_STUB === 'true' ? 'USE_MOCK' : process.env.NOTIFY_KEY,
     caseworkerEmail: process.env.CASEWORKER_EMAIL,

package.json

@@ -51,7 +51,6 @@
     "eslint-config-hof": "^1.2.1",
     "express": "^4.17.1",
     "funkie": "^0.0.6",
-    "funkie-chromedriver": "^0.1.0",
     "mocha": "^9.0.3",
     "nyc": "^15.1.0",
     "playwright": "^1.39.0",

server.js

@@ -35,7 +35,7 @@ const app = hof(settings);
 app.use((req, res, next) => {
   res.locals.htmlLang = 'en';
   // Set feedback url, required to display phase banner
-  res.locals.feedbackUrl = 'https://eforms.homeoffice.gov.uk/outreach/feedback.ofml';
+  res.locals.feedbackUrl = config.feedbackUrl;
   res.locals.startPageRedirectUrl = config.startPageRedirectUrl;
   res.locals.footerSupportLinks = [
     { path: '/cookies', property: 'base.cookies' },