Skip to content

Commit 01b5e4c

Browse files
committed
Added fix for broken handling of "Bypass" value
1 parent 360875b commit 01b5e4c

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

cwms-data-api/src/test/java/fixtures/CwmsDataApiSetupCallback.java

+5-7
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.io.InputStream;
66
import java.io.InputStreamReader;
77
import java.io.StringReader;
8-
import java.security.KeyException;
98
import java.sql.SQLException;
109
import java.util.ArrayList;
1110
import java.util.List;
@@ -34,7 +33,6 @@
3433
import io.restassured.filter.log.LogDetail;
3534
import io.restassured.path.json.config.JsonPathConfig;
3635
import javax.servlet.http.HttpServletResponse;
37-
import org.testcontainers.images.ImagePullPolicy;
3836
import org.testcontainers.images.PullPolicy;
3937

4038
import static io.restassured.RestAssured.given;
@@ -77,7 +75,7 @@ public class CwmsDataApiSetupCallback implements BeforeAllCallback,AfterAllCallb
7775

7876
private static String schemaVersion()
7977
{
80-
String ret = "Unknown";
78+
String ret;
8179
if (!System.getProperty(CwmsDatabaseContainers.BYPASS_URL,"").isEmpty())
8280
{
8381
ret = "Bypass";
@@ -95,9 +93,9 @@ else if (ORACLE_IMAGE.contains("database-ready"))
9593

9694
private static int versionInt()
9795
{
98-
int ret = -999999;
96+
int ret;
9997
String tmp = schemaVersion();
100-
if (tmp.equalsIgnoreCase("latest-dev")) {
98+
if (tmp.equalsIgnoreCase("latest-dev") || tmp.equalsIgnoreCase("Bypass")) {
10199
ret = 999999;
102100
}
103101
else if(tmp.toLowerCase().endsWith("staging")) {
@@ -198,7 +196,7 @@ private void loadTimeSeriesData(CwmsDatabaseContainer<?> cwmsDb2) {
198196
StringReader reader = new StringReader(csv);
199197
try {
200198
List<TsRandomSampler.TsSample> samples = TsRandomSampler.load_data(reader);
201-
cwmsDb2.connection( (c) -> {
199+
cwmsDb2.connection( c -> {
202200
TsRandomSampler.save_to_db(samples, c);
203201
},"cwms_20");
204202
} catch (IOException e) {
@@ -213,7 +211,7 @@ private void loadTimeSeriesData(CwmsDatabaseContainer<?> cwmsDb2) {
213211
private void loadDefaultData(CwmsDatabaseContainer cwmsDb) throws SQLException {
214212
ArrayList<String> defaultList = getDefaultList();
215213
for( String data: defaultList){
216-
String user_resource[] = data.split(":");
214+
String[] user_resource = data.split(":");
217215
String user = user_resource[0];
218216
if( user.equalsIgnoreCase("dba")){
219217
user = cwmsDb.getDbaUser();

0 commit comments

Comments
 (0)