Skip to content

Commit aa97914

Browse files
committed
Move DBusBridge functionality into DBusIPCServerPrivate.
1 parent 480d38d commit aa97914

9 files changed

+722
-1132
lines changed

Makefile.am

Lines changed: 15 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,8 @@ libusbguard_la_SOURCES=\
244244
src/Library/KeyValueParserPrivate.hpp \
245245
src/Library/LocaltimeCondition.cpp \
246246
src/Library/LocaltimeCondition.hpp \
247+
src/Library/QBIPCServerPrivate.cpp \
248+
src/Library/QBIPCServerPrivate.hpp \
247249
src/Library/RandomStateCondition.cpp \
248250
src/Library/RandomStateCondition.hpp \
249251
src/Library/RuleAppliedCondition.cpp \
@@ -437,45 +439,33 @@ usbguard_rule_parser_LDADD=\
437439
# DBus Bridge
438440
#
439441
if DBUS_ENABLED
440-
sbin_PROGRAMS+= usbguard-dbus
442+
libusbguard_la_SOURCES+= \
443+
src/Library/DBusIPCServerPrivate.cpp \
444+
src/Library/DBusIPCServerPrivate.hpp
445+
446+
libusbguard_la_CPPFLAGS+=\
447+
-I$(top_builddir)/src/DBus \
448+
@dbus_CFLAGS@
449+
450+
libusbguard_la_LIBADD+=\
451+
@dbus_LIBS@
441452

442453
if DOCS_ENABLED
443454
man8_MANS+=\
444455
$(top_builddir)/doc/man/usbguard-dbus.8
445456
endif
446457

447458
BUILT_SOURCES+=\
448-
src/DBus/DBusInterface.xml.cstr \
449-
src/DBus/org.usbguard.service \
450-
src/DBus/usbguard-dbus.service
459+
src/DBus/DBusInterface.xml.cstr
451460

452461
EXTRA_DIST+=\
453462
src/DBus/org.usbguard.conf \
454-
src/DBus/org.usbguard.service.in \
455-
src/DBus/usbguard-dbus.service.in \
456463
src/DBus/org.usbguard.policy \
457464
src/DBus/DBusInterface.xml
458465

459466
CLEANFILES+=\
460-
$(top_builddir)/src/DBus/org.usbguard.service \
461-
$(top_builddir)/src/DBus/usbguard-dbus.service \
462467
$(top_builddir)/src/DBus/DBusInterface.xml.cstr
463468

464-
usbguard_dbus_SOURCES=\
465-
src/DBus/gdbus-server.cpp \
466-
src/DBus/DBusBridge.cpp \
467-
src/DBus/DBusBridge.hpp
468-
469-
usbguard_dbus_CPPFLAGS=\
470-
-fPIE \
471-
$(AM_CPPFLAGS) \
472-
-I$(top_builddir)/src/DBus \
473-
@dbus_CFLAGS@
474-
475-
usbguard_dbus_LDADD=\
476-
$(top_builddir)/libusbguard.la \
477-
@dbus_LIBS@
478-
479469
%.xml:
480470
xmllint "$(top_srcdir)/$@" > /dev/null
481471

@@ -486,15 +476,11 @@ usbguard_dbus_LDADD=\
486476
%.service: %.service.in
487477
sed -e "s|%{sbindir}%|$(sbindir)|" "$<" > "$(top_builddir)/$@"
488478

489-
install-data-dbus: $(top_builddir)/src/DBus/org.usbguard.service install-polkit-policy install-systemd-dbus-service
490-
$(MKDIR_P) $(DESTDIR)$(DBUS_SERVICES_DIR) && \
491-
$(INSTALL_DATA) $(top_builddir)/src/DBus/org.usbguard.service $(DESTDIR)$(DBUS_SERVICES_DIR)
479+
install-data-dbus: $(top_builddir)/src/DBus/org.usbguard.service install-polkit-policy
492480
$(MKDIR_P) $(DESTDIR)$(DBUS_BUSCONFIG_DIR) && \
493481
$(INSTALL_DATA) $(top_srcdir)/src/DBus/org.usbguard.conf $(DESTDIR)$(DBUS_BUSCONFIG_DIR)
494482

495-
uninstall-data-dbus: uninstall-polkit-policy uninstall-systemd-dbus-service
496-
rm -f $(DESTDIR)$(DBUS_SERVICES_DIR)/org.usbguard.service
497-
rmdir $(DESTDIR)$(DBUS_SERVICES_DIR)
483+
uninstall-data-dbus: uninstall-polkit-policy
498484
rm -f $(DESTDIR)$(DBUS_BUSCONFIG_DIR)/org.usbguard.conf
499485
rmdir $(DESTDIR)$(DBUS_BUSCONFIG_DIR)
500486

@@ -529,19 +515,6 @@ install-polkit-policy:
529515
uninstall-polkit-policy:
530516
endif
531517

532-
if SYSTEMD_SUPPORT_ENABLED
533-
install-systemd-dbus-service: $(top_builddir)/src/DBus/usbguard-dbus.service
534-
$(MKDIR_P) $(DESTDIR)$(SYSTEMD_UNIT_DIR) && \
535-
$(INSTALL_DATA) $(top_builddir)/src/DBus/usbguard-dbus.service $(DESTDIR)$(SYSTEMD_UNIT_DIR)
536-
537-
uninstall-systemd-dbus-service:
538-
rm -f $(DESTDIR)$(SYSTEMD_UNIT_DIR)/usbguard-dbus.service
539-
rmdir $(DESTDIR)$(SYSTEMD_UNIT_DIR)
540-
541-
else
542-
install-systemd-dbus-service:
543-
uninstall-systemd-dbus-service:
544-
endif
545518
else
546519
install-data-dbus:
547520
uninstall-data-dbus:

configure.ac

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ esac
408408
#
409409
# GLib D-Bus
410410
#
411-
AC_ARG_WITH([dbus], AC_HELP_STRING([--with-dbus], [Build the DBus Bridge service]), [], [with_dbus=yes])
411+
AC_ARG_WITH([dbus], AC_HELP_STRING([--with-dbus], [Build with DBus support]), [], [with_dbus=yes])
412412
if test "x$with_dbus" = xyes; then
413413
#
414414
# Check for required D-Bus modules

0 commit comments

Comments
 (0)