basic_demo.ipynb check_valve must be a Boolean

[linasela]

when running 'basic_demo.ipynb' in section 3.6 with
Python 3.9.21
WNTR version: 1.2.0
the command wn2 = wntr.network.read_shapefile(shapefile_dirs) gives the following error:

[kaklise]

Thanks @linasela. I'm not able to replicate this issue. I see that check_valve is '0' and then converted to False. Can you send us the value of check_valve before the assert statement?

[linasela]

Thanks @kaklise, looks like it's boolean

Also, this is the same code we used in the workshop during the summer. You can run it in binder https://mybinder.org/v2/gh/meghnathomas/wdsa-ccwi-workshop/HEAD
and it generates the same error I get running it locally.

Thanks

[angusmcb]

I don't think that it's the cause of the issue, but note that I think you would need to check pipe.cv

See here: #468

[kaklise]

This issue seems to be related to the geopandas version. There is a requirement that geopandas must be < 1.0 for WNTR <= 1.3.2. That restriction has been resolved for the current (pre-release) version of WNTR (1.4.0 on the main branch), where the current release of geopandas can be used.

[kbonney]

@linasela I believe this issue was taken care of in #488. Please let me know if that fix works for you.