Skip to content

Commit 1035863

Browse files
committed
bug in NCriticsTwoHot when min/max_return = 0
1 parent 274278d commit 1035863

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

amago/nets/actor_critic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,8 +500,8 @@ def __init__(
500500
amago_warning(
501501
"amago.nets.actor_critic.NCriticsTwoHot.min_return/max_return have not been set manually, and default to extreme values."
502502
)
503-
min_return = min_return or -100_000
504-
max_return = max_return or 100_000
503+
min_return = min_return if min_return is not None else -100_000
504+
max_return = max_return if max_return is not None else 100_000
505505
self.transform_values = symlog if use_symlog else lambda x: x
506506
self.invert_bins = symexp if use_symlog else lambda x: x
507507
assert min_return < max_return

0 commit comments

Comments
 (0)