added error handling to return empty data array when invalid enum parameters are passed

Author: amyfromandi

v2/definitions/econs.ts

@@ -51,12 +51,19 @@ module.exports = function (req, res, next, cb) {
   }
 
   larkin.queryPg("burwell", sql, params, function (error, data) {
+    console.log("CALLBACK DATA ", cb);
     if (error) {
+      console.log("The error still returned from larkin")
       if (cb) {
         cb(error);
+      } else if (error == "{\"success\":{\"v\":2,\"license\":\"CC-BY 4.0\",\"data\":[]}}") {
+        console.log("THIS IS A SUCCESS JSON EVEN THOUGH IT'S CALLED ERROR", error)
+        error = JSON.parse(error);
+        res.status(200).json(error);
       } else {
-        return larkin.error(req, res, next, error);
+        larkin.error(req, res, next, error);
       }
+      return
     }
 
     if (cb) {

v2/larkin.ts

@@ -112,10 +112,9 @@ const { Client, Pool } = require("pg");
         connectionDetails.database = 'rockd'
       }
     }
-    //TODO add error handling to keep api running if there are connection issues. Maybe implement pgpromise similar to rockd api?
-
     const pool = new Pool(connectionDetails);
     console.log(connectionDetails)
+    const errorMessage = "invalid input value for enum";
 
     pool.connect(function (err, client, done) {
       if (err) {
@@ -143,7 +142,13 @@ const { Client, Pool } = require("pg");
           done();
           if (err) {
             larkin.log("error", err);
-            callback(err);
+              if (err.message.includes(errorMessage)) {
+                const enumError = JSON.stringify({"success": {"v": 2,"license": "CC-BY 4.0", "data": []}});
+                callback(enumError);
+              }
+              else {
+                callback(err);
+              }
           } else {
             callback(null, result);
           }