Fixed name errors in camera_picamera2.py module (#78)

* Fixed name errors in camera_picamera2.py module

* Added conditional for class creation picam2

* fixed linter/formatting errors

* removed useless conditional

* fixed pylint issue

Author: BalajiLeninrajan

modules/camera/camera_picamera2.py

@@ -9,7 +9,7 @@
     import libcamera
     import picamera2
 except ImportError:
-    pass
+    picamera2 = None
 
 from . import base_camera
 
@@ -62,76 +62,93 @@ def to_dict(self) -> dict[str, int | float]:
         return camera_controls
 
 
-class CameraPiCamera2(base_camera.BaseCameraDevice):
-    """
-    Class for the Picamera2 implementation of the camera.
-    """
-
-    __create_key = object()
+if picamera2 is None:
 
-    @classmethod
-    def create(
-        cls, width: int, height: int, config: ConfigPiCamera2
-    ) -> "tuple[True, CameraPiCamera2] | tuple[False, None]":
+    class CameraPiCamera2(base_camera.BaseCameraDevice):
         """
-        Picamera2 Camera.
-
-        width: Width of the camera.
-        height: Height of the camera.
-        config: Configuration for PiCamera2 camera.
-
-        Return: Success, camera object.
+        Class for the Picamera2 import failure.
         """
-        if width <= 0:
-            return False, None
-
-        if height <= 0:
-            return False, None
-
-        try:
-            camera = picamera2.Picamera2()
-
-            camera_config = camera.create_preview_configuration(
-                {"size": (width, height), "format": "RGB888"}
-            )
-            camera.configure(camera_config)
-            camera.start()
-            controls = config.to_dict()
-            camera.set_controls(controls)
 
-            return True, CameraPiCamera2(cls.__create_key, camera, config)
-        except RuntimeError:
+        @classmethod
+        def create(cls, width: int, height: int, config: ConfigPiCamera2) -> "tuple[False, None]":
             return False, None
 
-    def __init__(
-        self,
-        class_private_create_key: object,
-        camera: picamera2.Picamera2,
-        config: ConfigPiCamera2,
-    ) -> None:
-        """
-        Private constructor, use create() method.
-        """
-        assert class_private_create_key is CameraPiCamera2.__create_key, "Use create() method."
+        def __init__(self) -> None:
+            pass
 
-        self.__camera = camera
-        self.__config = config
+else:
 
-    def __del__(self) -> None:
+    class CameraPiCamera2(base_camera.BaseCameraDevice):
         """
-        Destructor. Release hardware resources.
+        Class for the Picamera2 implementation of the camera.
         """
-        self.__camera.close()
-
-    def run(self) -> tuple[True, np.ndarray] | tuple[False, None]:
-        """
-        Takes a picture with Picamera2 camera.
-
-        Return: Success, image with shape (height, width, channels in BGR).
-        """
-        try:
-            image_data = self.__camera.capture_array(wait=self.__config.timeout)
-        except TimeoutError:
-            return False, None
 
-        return True, image_data
+        __create_key = object()
+
+        @classmethod
+        def create(
+            cls, width: int, height: int, config: ConfigPiCamera2
+        ) -> "tuple[True, CameraPiCamera2] | tuple[False, None]":
+            """
+            Picamera2 Camera.
+
+            width: Width of the camera.
+            height: Height of the camera.
+            config: Configuration for PiCamera2 camera.
+
+            Return: Success, camera object.
+            """
+
+            if width <= 0:
+                return False, None
+
+            if height <= 0:
+                return False, None
+
+            try:
+                camera = picamera2.Picamera2()
+
+                camera_config = camera.create_preview_configuration(
+                    {"size": (width, height), "format": "RGB888"}
+                )
+                camera.configure(camera_config)
+                camera.start()
+                controls = config.to_dict()
+                camera.set_controls(controls)
+
+                return True, CameraPiCamera2(cls.__create_key, camera, config)
+            except RuntimeError:
+                return False, None
+
+        def __init__(
+            self,
+            class_private_create_key: object,
+            camera: picamera2.Picamera2,  # type: ignore
+            config: ConfigPiCamera2,
+        ) -> None:
+            """
+            Private constructor, use create() method.
+            """
+            assert class_private_create_key is CameraPiCamera2.__create_key, "Use create() method."
+
+            self.__camera = camera
+            self.__config = config
+
+        def __del__(self) -> None:
+            """
+            Destructor. Release hardware resources.
+            """
+            self.__camera.close()
+
+        def run(self) -> tuple[True, np.ndarray] | tuple[False, None]:
+            """
+            Takes a picture with Picamera2 camera.
+
+            Return: Success, image with shape (height, width, channels in BGR).
+            """
+            try:
+                image_data = self.__camera.capture_array(wait=self.__config.timeout)
+            except TimeoutError:
+                return False, None
+
+            return True, image_data