Add room information for calendar export

[alfredzimmer]

When term information is being pasted in, the room information is not properly imported and therefore when being exported it shows unknown location. Is it just me who had this issue? I'm willing to provide information that recreates this issue.

Thanks in advance.

[AD1938]

I don't think the room information is parsed while you paste term information. See flow/api/parse/schedule/schedule.go.

[alfredzimmer]

That explains it. Is that feature planned to be supported? I'd be happy to work on it and submit a PR.

[AD1938]

Thank you for the suggestion! Sounds like a fair feature to work on.

Just to make sure this is only for the convenience for exporting to personal calendar right? I think we need to be careful that we do not show these room information publicly.

I’ve assigned this issue to you. Feel free to comment further here, or drop your contact info if you’d like more support.

[a23kumar]

Hi @alfredzimmer. I was hacking away at this bug but did not realize that it was already an issue that was created. I have attached a draft PR of a version that I think works. If you think my PR is good, we can put that up for review, otherwise feel free to ignore it. Regardless, I will leave the draft PR as a reference in the chance that you find any value in it to complete this issue.

[alfredzimmer]

Thanks for the code. I'll pull your branch and update the calendar exporter on top of it. Then, I'll open a new PR with the full fix and give you co author credit.

[SamirRSharma]

I would just be careful with the UW api rules. I dont remember the details, but after the HH stabing uwflow was forced to remove the room info. So idk if this is allowed, but I may be wrong. Just want to double-check so it does not get in trouble. Seems like a very useful feature.

[alfredzimmer]

As per my understanding, the personal schedule is created by the user themself pasting their semester information in—that includes the room info—and would be stored separately and privately within the user's account. I am thinking of building a feature that parses the user's input classroom, adds to their personal schedule on uwflow and allows for exporting that information to an calendar file. The entire process should not invovle neither scraping room data diretly from the UW Open Data API nor would be leaked to the public that violates Policy 46.

[SamirRSharma]

Makes sense to me. I didnt go over the code, I just know we had problems with the APIs in the past. This approach makes complete sense to me with avoiding using any APIs.

The only thing is, I am 90% sure this already exists: https://questscheduleexporter.stephenli.ca/

[alfredzimmer]

Thanks for the heads up. It does exist but for one thing that repo is deprecated and another is that uwflow has not implemented that feature so far.

[SamirRSharma]

Fair, just wanted to make sure you were aware of it. Best of luck with the feature

[SamirRSharma]

Wait @alfredzimmer looking at the open PR, it mentions parsing the API?

#172