Merge pull request #68 from UWIT-IAM/GH-67

[GH-67] update tests for DUOs slight change of a link to a button and update outdated commands

Author: goulter

Dockerfile

@@ -1,9 +1,9 @@
 # The poetry image is built often, so pinning to avoid breaking changes
 FROM ghcr.io/uwit-iam/poetry:2025.04.02T012232 AS apt-base
-ENV ALLOW_HOSTS_MODIFICATION "1"
+ENV ALLOW_HOSTS_MODIFICATION="1"
 RUN apt-get update && apt-get -y install curl jq dnsutils
 
-FROM apt-base as poetry-base
+FROM apt-base AS poetry-base
 WORKDIR /uw-idp-tests
 COPY poetry.lock pyproject.toml scripts/entrypoint.sh ./
 RUN poetry install --no-root

tests/conftest.py

@@ -174,8 +174,8 @@ def duo_push(current_browser: Chrome):
     Select the other duo option, to get to the bypass code option
     """
     wait = WebDriverWait(current_browser, 10)
-    wait.until(EC.element_to_be_clickable((By.XPATH, "//a[contains(text(), 'Other options')]")))
-    current_browser.wait_for_tag('a', 'Other options').click()
+    wait.until(EC.element_to_be_clickable((By.XPATH, "//button[contains(text(), 'Other options')]")))
+    current_browser.wait_for_tag('button', 'Other options').click()
     current_browser.wait_for_tag('b', 'Other options to log in')
 
 

tests/test_2fa_duo.py

@@ -196,7 +196,7 @@ def test_remember_me_cookie(
         Select the other duo option, to get to the bypass code option
         """
         wait = WebDriverWait(fresh_browser, 10)
-        wait.until(EC.element_to_be_clickable((By.XPATH, "//a[contains(text(), 'Other options')]")))
+        wait.until(EC.element_to_be_clickable((By.XPATH, "//button[contains(text(), 'Other options')]")))
         enter_duo_passcode(fresh_browser, match_service_provider=sp, select_this_is_my_device=True)
 
         # go to an idp site to retrieve the shib idp cookies