Backend Onboarding

Author: 19prishpat

backend/api/endpoints/command.py

@@ -24,23 +24,35 @@ def get_commands(db: Session = Depends(get_db)):
 
 
 @command_router.post("/", response_model=CommandSingleResponse)
-def create_command(payload: CommandRequest):
+def create_command(payload: CommandRequest, db: Session = Depends(get_db)):
     """
     Creates an item with the given payload in the database and returns this payload after pulling it from the database 
 
     @param payload: The data used to create an item
     @return returns a json object with field of "data" under which there is the payload now pulled from the database 
     """
     # TODO:(Member) Implement this endpoint
+    command = Command(**payload.model_dump())
+    db.add(command)
+    db.commit()
+    db.refresh(command)
+    return {"data": command}
 
 
 
 @command_router.delete("/{id}", response_model=CommandListResponse)
-def delete_command(id: int):
+def delete_command(id: int, db: Session = Depends(get_db)):
     """
     Deletes the item with the given id if it exists. Otherwise raises a 404 error.
 
     @param id: The id of the item to delete
     @return returns the list of commands after deleting the item
     """
     # TODO:(Member) Implement this endpoint
+    command = db.get(Command, id)
+    if not command:
+        raise HTTPException(status_code=404, detail="Command not found")
+    db.delete(command)
+    db.commit()
+    items = db.exec(select(Command)).all()
+    return {"data": items}

backend/api/middlewares/logger_middleware.py

@@ -1,8 +1,12 @@
+import time
+from datetime import datetime
 from collections.abc import Callable
 from typing import Any
 from fastapi import Request, Response
 from starlette.middleware.base import BaseHTTPMiddleware
 
+import logging
+custom_logger = logging.getLogger("my_logger")
 
 class LoggerMiddleware(BaseHTTPMiddleware):
     async def dispatch(
@@ -18,5 +22,22 @@ async def dispatch(
         @return Response from endpoint
         """
         # TODO:(Member) Finish implementing this method
+        start_time = time.time()
+        timestamp = datetime.utcnow().isoformat()
+
+        # Log incoming request
+        custom_logger.info(f"[{timestamp}] Incoming request: {request.method} {request.url}")
+        custom_logger.info(f"Headers: {dict(request.headers)}")
+        if request.query_params:
+            custom_logger.info(f"Query Params: {dict(request.query_params)}")
+
+        # Process request
         response = await call_next(request)
+
+        # Measure execution time
+        duration = time.time() - start_time
+        custom_logger.info(
+            f"Response status: {response.status_code} | Duration: {duration:.4f} seconds"
+        )
+
         return response

backend/data/data_models.py

@@ -33,7 +33,21 @@ def validate_params_format(self):
         The format of the comma seperated values is "data1,data2" so no spaces between data and the commas.
         """
         # TODO: (Member) Implement this method
-        return self
+        if self.params is None and self.format is None:
+            return self  # Valid case: both are None
+
+        if self.params is not None and self.format is not None:
+            params_count = len(self.params.split(","))
+            format_count = len(self.format.split(","))
+            if params_count == format_count:
+                return self  
+            else:
+                raise ValueError(
+                    f"Mismatch between number of params ({params_count}) and format items ({format_count})."
+                )
+
+    
+        raise ValueError("Both 'params' and 'format' must be None or must have the same number of comma-separated values.")
 
 
 class Command(BaseSQLModel, table=True):