Made fixes according to PR review, updated logger

Author: GabrielGuirguis

backend/api/endpoints/command.py

@@ -54,7 +54,7 @@ def delete_command(id: int, db: Session = Depends(get_db)):
     query = select(Command).where(Command.id == id)
     result = db.exec(query).first()
 
-    if not result:
+    if result is None:
         raise HTTPException(status_code=404, detail=f"Command with id {id} not found.")
 
     db.delete(result)

backend/api/middlewares/logger_middleware.py

@@ -24,5 +24,5 @@ async def dispatch(
         response = await call_next(request)
 
         duration = perf_counter() - start
-        logger.info
+        logger.info(f"Response sent in {duration} seconds to Request params: {request.path_params}")
         return response

backend/data/data_models.py

@@ -32,22 +32,13 @@ def validate_params_format(self):
         In either of these cases return self. Otherwise raise a ValueError.
         The format of the comma seperated values is "data1,data2" so no spaces between data and the commas.
         """
-        validated_params = self.params
-        validated_format = self.format
 
-        if validated_params == None and validated_format == None:
+        if self.params is None and self.format is None:
             return self
-        elif isinstance(validated_params, str) and (isinstance(validated_format, str)) and validated_params.count(",") == validated_format.count(","):
+        elif isinstance(self.params, str) and isinstance(self.format, str) and self.params.count(",", 0, -1) == self.format.count(",", 0, -1):
             return self
-        else:
-            raise(ValueError
-                  (f"""params and format must both be either None or have the same number of comma seperated values,
-                    recieved: 
-                        params: {validated_params}
-                        format: {validated_format}\n"""))
-
-        return self
-
+        
+        raise ValueError("Params and format either both be None or have the same number of comma separated values.")
 
 class Command(BaseSQLModel, table=True):
     """

frontend/src/display/command_api.ts

@@ -22,8 +22,7 @@ export const getCommands = async (): Promise<CommandListResponse> => {
  */
 export const deleteCommand = async (id: number): Promise<CommandListResponse> => {
   try {
-    await axios.delete(`${API_URL}/${id}`)
-    const { data } = await axios.get<CommandListResponse>(`${API_URL}/commands/`)
+    const { data } = await axios.delete(`${API_URL}/${id}`)
     return data;
   } catch (error) {
     console.error(error)