Skip to content

Commit 24dca0c

Browse files
Brain256Brain256
authored andcommitted
update backend config files
1 parent c840373 commit 24dca0c

File tree

5 files changed

+6
-11
lines changed

5 files changed

+6
-11
lines changed

gs/backend/config/config.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# TODO:(335) Improve loading the configuration
22

3-
from .cors_config import CORSConfig
4-
from .database_config import DatabaseConfig
5-
from .logger_config import LoggerConfig
3+
from gs.backend.config.cors_config import CORSConfig
4+
from gs.backend.config.database_config import DatabaseConfig
5+
from gs.backend.config.logger_config import LoggerConfig
66

77

88
class BackendConfiguration:

gs/backend/config/database_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ class DatabaseConfig(BaseSettings):
1515
port: int
1616
name: str
1717

18+
@property
1819
def connection_string(self) -> str:
1920
"""
2021
Returns the database connection string

gs/backend/data/database/engine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def get_db_engine() -> Engine:
1313
1414
:return: engine
1515
"""
16-
return create_engine(settings.db.connection_string())
16+
return create_engine(settings.db.connection_string)
1717

1818

1919
def get_db_session() -> Session:

package-lock.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

python_test/test_config_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def test_database_connection_string():
5454

5555
assert db.password.get_secret_value() == "testpassword"
5656
expected_url = "postgresql://testuser:testpassword@localhost:5432/testdb"
57-
assert db.connection_string() == expected_url
57+
assert db.connection_string == expected_url
5858

5959

6060
def test_database_missing_env(monkeypatch):

0 commit comments

Comments
 (0)