Skip to content

Commit 52dee84

Browse files
authored
Merge branch 'main' into eddie/callsign_upgrade
2 parents 247a799 + c46f415 commit 52dee84

File tree

2 files changed

+29
-7
lines changed

2 files changed

+29
-7
lines changed

gs/backend/config/config.py

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,27 @@ def __init__(self) -> None:
2222

2323
backend_config = BackendConfiguration()
2424

25-
# TODO: Make these throw an exception if they are None
26-
GS_DATABASE_USER = environ.get("GS_DATABASE_USER")
27-
GS_DATABASE_PASSWORD = environ.get("GS_DATABASE_PASSWORD")
28-
GS_DATABASE_LOCATION = environ.get("GS_DATABASE_LOCATION")
29-
GS_DATABASE_PORT = environ.get("GS_DATABASE_PORT")
30-
GS_DATABASE_NAME = environ.get("GS_DATABASE_NAME")
25+
26+
def getenv(config: str) -> str:
27+
"""
28+
Validates whether or not database env values exist in .env. If not, throws a value error.
29+
30+
:param config: Variable in .env
31+
:type config: str
32+
:return: Value of variable in .env
33+
:rtype: str
34+
"""
35+
value = environ.get(config)
36+
if not value:
37+
raise ValueError(f"{config} is missing from .env.")
38+
return value
39+
40+
41+
GS_DATABASE_USER = getenv("GS_DATABASE_USER")
42+
GS_DATABASE_PASSWORD = getenv("GS_DATABASE_PASSWORD")
43+
GS_DATABASE_LOCATION = getenv("GS_DATABASE_LOCATION")
44+
GS_DATABASE_PORT = getenv("GS_DATABASE_PORT")
45+
GS_DATABASE_NAME = getenv("GS_DATABASE_NAME")
3146

3247
DATABASE_CONNECTION_STRING: Final[
3348
str

migrations/env.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
from sqlalchemy import engine_from_config, pool
77
from sqlmodel import SQLModel
88

9+
from gs.backend.data.tables import aro_user_tables, main_tables, transactional_tables # noqa: F401
10+
911
load_dotenv()
1012

1113
SQLALCHEMY_DATABASE_URL = os.getenv("SQLALCHEMY_DATABASE_URL")
@@ -55,6 +57,7 @@ def run_migrations_offline() -> None:
5557
target_metadata=target_metadata,
5658
literal_binds=True,
5759
dialect_opts={"paramstyle": "named"},
60+
include_schemas=True,
5861
)
5962

6063
with context.begin_transaction():
@@ -76,7 +79,11 @@ def run_migrations_online() -> None:
7679
)
7780

7881
with connectable.connect() as connection:
79-
context.configure(connection=connection, target_metadata=target_metadata)
82+
context.configure(
83+
connection=connection,
84+
target_metadata=target_metadata,
85+
include_schemas=True,
86+
)
8087

8188
with context.begin_transaction():
8289
context.run_migrations()

0 commit comments

Comments
 (0)