Requested changes

Author: Guhan Iyer

obc/app/drivers/rm46/obc_gio_ctrl.c

@@ -5,7 +5,6 @@
 #include "alarm_handler.h"
 #include "obc_board_config.h"
 #include "tpl5010.h"
-#include "obc_logging.h"
 
 void gioNotification(gioPORT_t *port, uint32 bit) {
   if (port == gioPORTA) {

obc/app/drivers/rm46/obc_i2c_io.c

@@ -103,6 +103,7 @@ obc_error_code_t i2cReceiveFrom(uint8_t sAddr, uint16_t size, uint8_t *buf, Tick
 
   if (xSemaphoreTake(i2cTransferComplete, transferTimeoutTicks) != pdTRUE) {
     errCode = OBC_ERR_CODE_I2C_TRANSFER_TIMEOUT;
+    LOG_ERROR_CODE("Semaphore cannot be given or was already given.");
     i2cSetStop(I2C_REG);
   } else {
     errCode = OBC_ERR_CODE_SUCCESS;

obc/app/modules/alarm_mgr/alarm_handler.c

@@ -224,10 +224,8 @@ void alarmInterruptCallback(void) {
 
   alarm_handler_event_t event = {.id = ALARM_HANDLER_ALARM_TRIGGERED};
   xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken);
-  if (xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken) == pdTRUE) {
-    LOG_DEBUG_FROM_ISR("Alarm callback called; data sent to front of queue.");
-  } else {
-    LOG_ERROR_FROM_ISR("Alarm callback failed.");
+  if (xQueueSendToFrontFromISR(alarmHandlerQueueHandle, (void *)&event, &xHigherPriorityTaskWoken) != pdTRUE) {
+    LOG_ERROR_CODE("Alarm callback failed.");
   }
 
   if (xHigherPriorityTaskWoken) {

obc/app/modules/comms_link_mgr/cc1120_txrx.c

@@ -388,7 +388,7 @@ void txFifoReadyCallback(void) {
   // give semaphore and set xHigherPriorityTaskAwoken to pdTRUE if this unblocks a higher priority task than the current
   // one
   if (xSemaphoreGiveFromISR(txSemaphore, &xHigherPriorityTaskAwoken) != pdPASS) {
-    LOG_ERROR_FROM_ISR("TX FIFO below spec.");
+    LOG_ERROR_CODE("TX FIFO below spec.");
   }
   // if xHigherPriorityTaskAwoken == pdTRUE then request a context switch since this means a higher priority task has
   // been unblocked
@@ -400,7 +400,7 @@ void rxFifoReadyCallback(void) {
   // give semaphore and set xHigherPriorityTaskAwoken to pdTRUE if this unblocks a higher priority task than the current
   // one
   if (xSemaphoreGiveFromISR(rxSemaphore, &xHigherPriorityTaskAwoken) != pdPASS) {
-    LOG_ERROR_FROM_ISR("RX FIFO above threshold.");
+    LOG_ERROR_CODE(OBC_ERR_CODE_QUEUE_FULL);
   }
   // if xHigherPriorityTaskAwoken == pdTRUE then request a context switch since this means a higher priority task has
   // been unblocked
@@ -412,7 +412,7 @@ void txFifoEmptyCallback(void) {
   // give semaphore and set xHigherPriorityTaskAwoken to pdTRUE if this unblocks a higher priority task than the current
   // one
   if (xSemaphoreGiveFromISR(txFifoEmptySemaphore, &xHigherPriorityTaskAwoken) != pdPASS) {
-    LOG_ERROR_FROM_ISR("TX FIFO is empty.");
+    LOG_ERROR_CODE(OBC_ERR_CODE_QUEUE_EMPTY);
   }
   // if xHigherPriorityTaskAwoken == pdTRUE then request a context switch since this means a higher priority task has
   // been unblocked
@@ -424,7 +424,7 @@ void syncEventCallback(void) {
   // give semaphore and set xHigherPriorityTaskAwoken to pdTRUE if this unblocks a higher priority task than the current
   // one
   if (xSemaphoreGiveFromISR(syncReceivedSemaphore, &xHigherPriorityTaskAwoken) != pdPASS) {
-    LOG_ERROR_FROM_ISR("Sync word receieved.");
+    LOG_ERROR_CODE("Sync word receieved.");
   }
   // if xHigherPriorityTaskAwoken == pdTRUE then request a context switch since this means a higher priority task has
   // been unblocked