Open
Conversation
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
camspec
requested changes
Feb 8, 2026
Member
camspec
left a comment
camspec
left a comment
There was a problem hiding this comment.
Looks good but we should double-check the formula, if we could get a confirmation from Finn it would be nice but that may not be possible
| """ | ||
| @brief Computes relative velocity between satellite and observer | ||
| @param satellite: EarthSatellite object | ||
| @param observer_latitude_degree: Latitude of observer in degrees |
Member
There was a problem hiding this comment.
This docstring should match the param name
| @returns Doppler-shift frequency in Hz | ||
| """ | ||
| return frequency_hz * ( | ||
| ((SPEED_OF_LIGHT_METERS_PER_SECOND + relative_velocity_m_s) / SPEED_OF_LIGHT_METERS_PER_SECOND) - 1 |
Member
There was a problem hiding this comment.
Finn might've made a mistake with his formula, this simplifies to frequency_hz * (relative_velocity_m_s / speed of light), but I'm pretty sure it's frequency_hz * (speed of light / (speed of light + relative_velocity_m_s))
Member
There was a problem hiding this comment.
We're trying to get the observed frequency itself but this seems closer to an approximation of the shift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #355
Addresses changes requested to doppler shift calculator
New Changes
Addresses changes requested to doppler shift calculator
Testing
Outstanding Changes
If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.