fix: make span_id and trace_id required in _ingest_escalation_memory

These should not be nullable — the caller resolves them from OTel
context before calling. Removed "unknown" fallbacks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: mjnovice

src/uipath_langchain/agent/tools/escalation_tool.py

@@ -542,8 +542,8 @@ async def _ingest_escalation_memory(
     memory_space_id: str,
     answer: str,
     attributes: str,
-    span_id: str = "",
-    trace_id: str = "",
+    span_id: str,
+    trace_id: str,
     folder_path: str | None = None,
 ) -> None:
     """Persist a resolved escalation outcome into memory.
@@ -559,8 +559,8 @@ async def _ingest_escalation_memory(
         from uipath.platform.memory import EscalationMemoryIngestRequest
 
         request = EscalationMemoryIngestRequest(
-            span_id=span_id or "unknown",
-            trace_id=trace_id or "unknown",
+            span_id=span_id,
+            trace_id=trace_id,
             answer=answer,
             attributes=attributes,
         )

tests/agent/tools/test_escalation_memory.py

@@ -92,10 +92,6 @@ async def test_returns_none_on_failure(self, mock_uipath_cls: MagicMock) -> None
 
 
 class TestIngestEscalationMemory:
-    @pytest.mark.asyncio
-    async def test_noop_when_no_space_id(self) -> None:
-        await _ingest_escalation_memory(None, answer="yes", attributes="{}")
-
     @pytest.mark.asyncio
     @patch("uipath_langchain.agent.tools.escalation_tool.UiPath")
     async def test_calls_ingest(self, mock_uipath_cls: MagicMock) -> None:
@@ -104,7 +100,11 @@ async def test_calls_ingest(self, mock_uipath_cls: MagicMock) -> None:
         mock_sdk.memory.escalation_ingest_async = AsyncMock()
 
         await _ingest_escalation_memory(
-            "space-123", answer='{"approved": true}', attributes='{"input": "test"}'
+            "space-123",
+            answer='{"approved": true}',
+            attributes='{"input": "test"}',
+            span_id="abc123",
+            trace_id="def456",
         )
 
         mock_sdk.memory.escalation_ingest_async.assert_called_once()
@@ -119,4 +119,10 @@ async def test_graceful_on_failure(self, mock_uipath_cls: MagicMock) -> None:
         )
 
         # Should not raise
-        await _ingest_escalation_memory("space-123", answer="yes", attributes="{}")
+        await _ingest_escalation_memory(
+            "space-123",
+            answer="yes",
+            attributes="{}",
+            span_id="abc123",
+            trace_id="def456",
+        )