fix: claude review comments

Author: Sarath1018

docs/oauth-scopes.md

@@ -154,6 +154,9 @@ The `ConversationalAgents` scope is required for real-time WebSocket sessions (`
 |--------|-------------|
 | `getAll()` | `Traces.Api` |
 | `getById()` | `Traces.Api` |
+| `create()` | `Traces.Api` |
+| `updateById()` | `Traces.Api` |
+| `deleteById()` | `Traces.Api` |
 
 ## Processes
 

src/services/agents/feedback/feedback.ts

@@ -209,7 +209,7 @@ export class FeedbackService extends BaseService implements FeedbackServiceModel
     if (!id) throw new ValidationError({ message: 'Feedback ID is required for deleteById' });
     if (!options?.folderKey) throw new ValidationError({ message: 'folderKey is required for deleteById' });
 
-    await super.delete(
+    await this.delete(
       FEEDBACK_ENDPOINTS.DELETE(id),
       { headers: createHeaders({ [FOLDER_KEY]: options.folderKey }) }
     );

tests/integration/shared/agents/feedback.integration.test.ts

@@ -169,8 +169,11 @@ describe.each(modes)('Agent Feedback - Integration Tests [%s]', (mode) => {
 
     it('should delete a feedback entry', async () => {
       const created = await feedback.create({ traceId, isPositive: true, comment: 'To be deleted', folderKey });
+      createdIds.push(created.id);
+      registerResource('feedbackEntries', { id: created.id, folderKey });
 
       await feedback.deleteById(created.id, { folderKey });
+      createdIds.splice(createdIds.indexOf(created.id), 1);
     });
   });
 });

tests/integration/utils/cleanup.ts

@@ -140,8 +140,9 @@ export async function cleanupTestFeedbackEntry(
   try {
     const { feedback } = getServices();
     if (!feedback) return;
+    if (!folderKey) return;
     await retryWithBackoff(async () => {
-      await feedback.deleteById(id, { folderKey: folderKey! });
+      await feedback.deleteById(id, { folderKey });
     });
     console.log(`Cleaned up test feedback entry: ${id}`);
   } catch (error) {

tests/unit/services/agents/feedback.test.ts

@@ -159,8 +159,9 @@ describe('FeedbackService Unit Tests', () => {
       expect(mockApiClient.post).toHaveBeenCalledWith(
         FEEDBACK_ENDPOINTS.CREATE,
         expect.objectContaining({ traceId: FEEDBACK_TEST_CONSTANTS.TRACE_ID }),
-        expect.any(Object)
+        expect.objectContaining({ headers: expect.objectContaining({ 'X-UIPATH-FolderKey': FEEDBACK_TEST_CONSTANTS.FOLDER_KEY }) })
       );
+      expect(mockApiClient.post.mock.calls[0][1]).not.toHaveProperty('folderKey');
     });
 
     it('should transform createdAt and updatedAt to createdTime and updatedTime', async () => {
@@ -211,8 +212,9 @@ describe('FeedbackService Unit Tests', () => {
       expect(mockApiClient.post).toHaveBeenCalledWith(
         FEEDBACK_ENDPOINTS.UPDATE(FEEDBACK_TEST_CONSTANTS.FEEDBACK_ID),
         expect.objectContaining({ isPositive: false }),
-        expect.any(Object)
+        expect.objectContaining({ headers: expect.objectContaining({ 'X-UIPATH-FolderKey': FEEDBACK_TEST_CONSTANTS.FOLDER_KEY }) })
       );
+      expect(mockApiClient.post.mock.calls[0][1]).not.toHaveProperty('folderKey');
     });
 
     it('should transform createdAt and updatedAt to createdTime and updatedTime', async () => {
@@ -254,7 +256,7 @@ describe('FeedbackService Unit Tests', () => {
 
       expect(mockApiClient.delete).toHaveBeenCalledWith(
         FEEDBACK_ENDPOINTS.DELETE(FEEDBACK_TEST_CONSTANTS.FEEDBACK_ID),
-        expect.any(Object)
+        expect.objectContaining({ headers: expect.objectContaining({ 'X-UIPATH-FolderKey': FEEDBACK_TEST_CONSTANTS.FOLDER_KEY }) })
       );
     });