Apply code suggestions

CURA-12361

Author: wawanbreton

include/geometry/Point2D.h

@@ -46,7 +46,7 @@ class Point2D
     std::optional<Point2D> vNormalized() const
     {
         const double size = vSize();
-        if (is_null(size))
+        if (is_zero(size))
         {
             return std::nullopt;
         }

include/utils/Coord_t.h

@@ -39,15 +39,15 @@ template<utils::floating_point FactorType>
 }
 
 /*! Returns true if the given value is null or small enough to be considered null */
-[[nodiscard]] inline bool fuzzy_is_null(const coord_t value)
+[[nodiscard]] inline bool fuzzy_is_zero(const coord_t value)
 {
     return std::abs(value) <= EPSILON;
 }
 
 /*! Returns true if the given values are equal or close enough to be considered equal */
 [[nodiscard]] inline bool fuzzy_equal(const coord_t a, const coord_t b)
 {
-    return fuzzy_is_null(b - a);
+    return fuzzy_is_zero(b - a);
 }
 
 /*! Returns true if the given values are not equal and different enough to be considered not equal */

include/utils/math.h

@@ -138,7 +138,7 @@ template<utils::floating_point T>
 
 /*! \brief Check if a value is very close to 0 */
 template<utils::floating_point T>
-[[nodiscard]] bool is_null(T value)
+[[nodiscard]] bool is_zero(T value)
 {
     return std::abs(value) < (std::numeric_limits<T>::epsilon() * 100.0);
 }
@@ -150,7 +150,7 @@ template<utils::floating_point T>
 template<utils::numeric T>
 [[nodiscard]] int8_t sign(T value)
 {
-    return value >= static_cast<T>(0) ? 1 : -1;
+    return std::signbit(value) ? -1 : 1;
 }
 
 } // namespace cura

src/bridge.cpp

@@ -70,8 +70,7 @@ struct TransformedSegment
 
     void updateMinMax()
     {
-        min_y = std::min(start.Y, end.Y);
-        max_y = std::max(start.Y, end.Y);
+        std::tie(min_y, max_y) = std::minmax(start.Y, end.Y);
     }
 
     /*!
@@ -330,7 +329,7 @@ coord_t evaluateBridgeLine(const coord_t line_y, const TransformedShape& transfo
             const double next_intersection_skin_area = skin_outline_intersections.front();
             const double next_intersection_supported_area = supported_regions_intersections.front();
 
-            if (is_null(next_intersection_skin_area - next_intersection_supported_area))
+            if (is_zero(next_intersection_skin_area - next_intersection_supported_area))
             {
                 next_intersection_is_skin_area = true;
                 next_intersection_is_supported_area = true;
@@ -753,7 +752,7 @@ struct ExpansionRange
             return data.segment.calculateOverlapping(other, expand_direction);
         }
 
-        if (other.min_y > (y_max() - EPSILON) || other.max_y < (y_min() - EPSILON))
+        if (fuzzy_is_greater_or_equal(other.min_y, y_max()) || fuzzy_is_lesser_or_equal(other.max_y, y_min()))
         {
             // Not on the same horizontal band, or very slightly overlapping , discard
             return std::nullopt;
@@ -1080,11 +1079,6 @@ std::tuple<Shape, AngleDegrees> makeBridgeOverInfillPrintable(
     // Perform a morphological closing to remove overlapping lines
     transformed_expanded_infill_below_skin_area = transformed_expanded_infill_below_skin_area.offset(EPSILON).offset(-EPSILON).intersection(infill_contour);
 
-    SVG svg(fmt::format("/tmp/skin_support.svg"), AABB(transformed_expanded_infill_below_skin_area));
-    svg.write(infill_below_skin_area, { .surface = { SVG::Color::BLUE } });
-    svg.write(infill_lines_below, { .line = { SVG::Color::MAGENTA, 0.4 } });
-    svg.write(transformed_expanded_infill_below_skin_area, { .surface = { SVG::Color::RED, 0.3 } });
-
     return { transformed_expanded_infill_below_skin_area, bridge_angle };
 }
 

src/utils/linearAlg2D.cpp

@@ -349,8 +349,7 @@ std::optional<coord_t> LinearAlg2D::lineHorizontalLineIntersection(const Point2L
 
 std::optional<coord_t> LinearAlg2D::segmentHorizontalLineIntersection(const Point2LL& p1, const Point2LL& p2, const coord_t line_y)
 {
-    const coord_t min_y = std::min(p1.Y, p2.Y);
-    const coord_t max_y = std::max(p1.Y, p2.Y);
+    const auto [min_y, max_y] = std::minmax(p1.Y, p2.Y);
 
     if (min_y > line_y || max_y < line_y)
     {

tests/utils/CoordTTest.cpp

@@ -11,13 +11,13 @@ namespace cura
 {
 // NOLINTBEGIN(*-magic-numbers)
 
-TEST(CoordTTest, TestFuzzyNull)
+TEST(CoordTTest, TestFuzzyZero)
 {
-    EXPECT_EQ(fuzzy_is_null(0), true);
-    EXPECT_EQ(fuzzy_is_null(2), true);
-    EXPECT_EQ(fuzzy_is_null(-2), true);
-    EXPECT_EQ(fuzzy_is_null(10), false);
-    EXPECT_EQ(fuzzy_is_null(-10), false);
+    EXPECT_EQ(fuzzy_is_zero(0), true);
+    EXPECT_EQ(fuzzy_is_zero(2), true);
+    EXPECT_EQ(fuzzy_is_zero(-2), true);
+    EXPECT_EQ(fuzzy_is_zero(10), false);
+    EXPECT_EQ(fuzzy_is_zero(-10), false);
 }
 
 TEST(CoordTTest, TestFuzzyEqual)