Skip to content

Commit 2095fcc

Browse files
committed
implement review comments
Contribute to NP-637
1 parent 1462bcb commit 2095fcc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/package.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ on:
4040

4141
jobs:
4242
conan-package:
43-
uses: ultimaker/cura-workflows/.github/workflows/conan-package.yml@NP-637_conan_v2_wasm
43+
uses: ultimaker/cura-workflows/.github/workflows/conan-package.yml@NP-637_conan_v2_wasm # FIXME: Use `main` branch
4444
with:
4545
platform_wasm: true
4646
secrets: inherit
4747

4848
npm-package:
4949
needs: [ conan-package ]
50-
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || contains(github.ref_name, 'NP-') || github.ref_name == '5.10') }} # FIXME: have a more generic way to determine release branches
51-
uses: ultimaker/cura-workflows/.github/workflows/npm-package.yml@NP-637_conan_v2_wasm
50+
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || startsWith(github.ref_name, 'NP-') || startsWith(github.ref_name, '5.')) }} # FIXME: have a more generic way to determine release branches
51+
uses: ultimaker/cura-workflows/.github/workflows/npm-package.yml@NP-637_conan_v2_wasm # FIXME: Use `main` branch
5252
with:
5353
package_version_full: ${{ needs.conan-package.outputs.package_version_full }}
5454
secrets: inherit

0 commit comments

Comments
 (0)