Skip to content

Commit 262c57f

Browse files
committed
Addressed review comments
Contribute to NP-637
1 parent 8a77e66 commit 262c57f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/gcodeanalyzer.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ jobs:
7575
7676
- name: Collect STL-files, run CuraEngine, output GCode-files
7777
run: |
78+
source build/Release/generators/conanrun.sh
7879
for file in `ls NightlyTestModels/*.stl`;
7980
do
8081
( time ./build/Release/CuraEngine slice --force-read-parent --force-read-nondefault -v -p -j $CURA_RESOURCES/definitions/ultimaker_s3.def.json -l $file -o `basename $file .stl`.gcode ) 2> `basename $file .stl`.time

.github/workflows/package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747

4848
npm-package:
4949
needs: [ conan-package ]
50-
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || contains(github.ref_name, 'NP-') || github.ref_name == '5.10') }}
50+
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || contains(github.ref_name, 'NP-') || github.ref_name == '5.10') }} # FIXME: have a more generic way to determine release branches
5151
uses: ultimaker/cura-workflows/.github/workflows/npm-package.yml@NP-637_conan_v2_wasm
5252
with:
5353
package_version_full: ${{ needs.conan-package.outputs.package_version_full }}

0 commit comments

Comments
 (0)