Skip to content

Commit 8fe8e76

Browse files
authored
Merge branch 'main' into CURA-12474_set-fixed-0-gap-for-brim-support
2 parents d6cf775 + a460338 commit 8fe8e76

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

.github/workflows/package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747

4848
npm-package:
4949
needs: [ conan-package ]
50-
if: ${{ github.event_name == 'push' && (github.ref_name == 'main' || startsWith(github.ref_name, 'NP-') || startsWith(github.ref_name, '5.')) }} # FIXME: have a more generic way to determine release branches
50+
if: ${{ ((github.event_name == 'push' && (github.ref_name == 'main' || startsWith(github.ref_name, 'NP-') || startsWith(github.ref_name, '5.'))) || (github.event_name == 'pull_request' && (github.base_ref == 'main' || startsWith(github.head_ref, '5.'))))}} # FIXME: have a more generic way to determine release branches
5151
uses: ultimaker/cura-workflows/.github/workflows/npm-package.yml@main
5252
with:
5353
package_version_full: ${{ needs.conan-package.outputs.package_version_full }}

include/plugins/pluginproxy.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#define PLUGINS_PLUGINPROXY_H
66

77
#include <chrono>
8+
#include <sstream>
89

910
#include <agrpc/asio_grpc.hpp>
1011
#include <agrpc/client_rpc.hpp>
@@ -275,7 +276,9 @@ class PluginProxy
275276

276277
// Metadata
277278
client_context.AddMetadata("cura-engine-uuid", slot_info.engine_uuid.data());
278-
client_context.AddMetadata("cura-thread-id", fmt::format("{}", std::this_thread::get_id()));
279+
std::stringstream strstrm;
280+
strstrm << std::this_thread::get_id();
281+
client_context.AddMetadata("cura-thread-id", strstrm.str());
279282
}
280283

281284
/**

src/communication/CommandLine.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ int CommandLine::loadJSON(const std::filesystem::path& json_filename, Settings&
509509
std::ifstream file(json_filename, std::ios::binary);
510510
if (! file)
511511
{
512-
spdlog::error("Couldn't open JSON file: {}", json_filename);
512+
spdlog::error("Couldn't open JSON file: {}", json_filename.generic_string());
513513
return 1;
514514
}
515515

@@ -695,7 +695,7 @@ std::optional<container_setting_map> CommandLine::readResolvedJsonValues(const s
695695
std::ifstream file(json_filename, std::ios::binary);
696696
if (! file)
697697
{
698-
spdlog::error("Couldn't open JSON file: {}", json_filename);
698+
spdlog::error("Couldn't open JSON file: {}", json_filename.generic_string());
699699
return std::nullopt;
700700
}
701701

src/gcodeExport.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -843,7 +843,7 @@ void GCodeExport::processInitialLayerTemperature(const SliceDataStorage& storage
843843
wait_start_extruder = true;
844844
break;
845845
default:
846-
if (used_extruders > 1 || getFlavor() == EGCodeFlavor::REPRAP)
846+
if (used_extruders > 1 || getFlavor() == EGCodeFlavor::REPRAP || ! extruders_used[0])
847847
{
848848
std::ostringstream tmp;
849849
tmp << "T" << start_extruder_nr;

0 commit comments

Comments
 (0)