Fix wrong returned index

wawanbreton · wawanbreton · commit c5eeccc5768e · 2025-03-17T10:06:48.000+01:00
CURA-12463 Shape::findInside is supposed to return NO_INDEX if there is no point inside, but when empty it was returning 0, which is definitely not a valid polygon index.
diff --git a/src/geometry/Shape.cpp b/src/geometry/Shape.cpp
@@ -262,7 +262,7 @@ size_t Shape::findInside(const Point2LL& p, bool border_result) const
 {
     if (empty())
     {
-        return 0;
+        return NO_INDEX;
     }
 
     // NOTE: Keep these vectors fixed-size, they replace an (non-standard, sized at runtime) arrays.

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ size_t Shape::findInside(const Point2LL& p, bool border_result) const`
`262`	`262`	`{`
`263`	`263`	`if (empty())`
`264`	`264`	`{`
`265`		`- return 0;`
	`265`	`+ return NO_INDEX;`
`266`	`266`	`}`
`267`	`267`
`268`	`268`	`// NOTE: Keep these vectors fixed-size, they replace an (non-standard, sized at runtime) arrays.`