From b3668fce35ba0bcf52bf006075b1f15c2fe59ee9 Mon Sep 17 00:00:00 2001 From: Remco Burema Date: Tue, 18 Mar 2025 15:37:12 +0100 Subject: [PATCH 1/2] Fix early-out also skipping support-meshes. Recently, we made an early-out for when there's no support generated (skipping the expensive support generation code), but only looked at wether or not there's overhang -- but support can also be generated when a mesh is a support mesh. CURA-12478 --- src/support.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/support.cpp b/src/support.cpp index 6630920d6b..2e4fccf45d 100644 --- a/src/support.cpp +++ b/src/support.cpp @@ -1014,7 +1014,8 @@ void AreaSupport::generateSupportAreasForMesh( return; } - if (ranges::all_of( + if ((! mesh.settings.get("support_mesh")) && + ranges::all_of( mesh.overhang_areas, [](const Shape& overhang_area) { From 9a7cc3ccdc7201ca279d16663f8631a02d5c5527 Mon Sep 17 00:00:00 2001 From: rburema <41987080+rburema@users.noreply.github.com> Date: Tue, 18 Mar 2025 14:38:17 +0000 Subject: [PATCH 2/2] Apply clang-format --- src/support.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/support.cpp b/src/support.cpp index 2e4fccf45d..b9d28ebe70 100644 --- a/src/support.cpp +++ b/src/support.cpp @@ -1014,8 +1014,8 @@ void AreaSupport::generateSupportAreasForMesh( return; } - if ((! mesh.settings.get("support_mesh")) && - ranges::all_of( + if ((! mesh.settings.get("support_mesh")) + && ranges::all_of( mesh.overhang_areas, [](const Shape& overhang_area) {