Add spdlog dependency and update CMake configuration for JS bindings

Author: saumyaj3

CMakeLists.txt

@@ -2,6 +2,7 @@ cmake_minimum_required(VERSION 3.20)
 cmake_policy(SET CMP0091 NEW)
 project(libnest2d)
 find_package(standardprojectsettings REQUIRED)
+find_package(spdlog REQUIRED)
 
 option(BUILD_SHARED_LIBS "Build shared libs instead of static (applies for dependencies as well)" OFF)
 option(HEADER_ONLY "If enabled static library will not be built." ON)
@@ -55,7 +56,7 @@ target_compile_definitions(project_options INTERFACE LIBNEST2D_GEOMETRIES_${GEOM
 
 if("${OPTIMIZER}" STREQUAL "nlopt")
     find_package(NLopt REQUIRED)
-    target_link_libraries(project_options INTERFACE NLopt::nlopt)
+    target_link_libraries(project_options INTERFACE NLopt::nlopt spdlog::spdlog)
     list(APPEND nest2d_HDRS
             include/libnest2d/optimizers/nlopt/simplex.hpp
             include/libnest2d/optimizers/nlopt/subplex.hpp

conanfile.py

@@ -89,6 +89,7 @@ def layout(self):
         self.cpp.package.includedirs = ["include"]
 
     def requirements(self):
+        self.requires("spdlog/[>=1.14.1]", transitive_headers=True)
         if self.options.geometries == "clipper":
             self.requires("clipper/6.4.2@ultimaker/stable", transitive_headers=True)
         if self.options.geometries == "boost" or self.options.geometries == "clipper":

libnest2d_js/CMakeLists.txt

@@ -34,6 +34,8 @@ target_link_libraries(libnest2d_js PRIVATE Boost::headers)
 target_link_libraries(libnest2d_js PRIVATE clipper::clipper)
 
 target_link_libraries(libnest2d_js PRIVATE NLopt::nlopt)
+
+target_link_libraries(libnest2d_js PUBLIC spdlog::spdlog)
 # Define backend macro for Emscripten
 target_compile_definitions(libnest2d_js PRIVATE LIBNEST2D_GEOMETRIES_clipper)
 target_compile_definitions(libnest2d_js PRIVATE LIBNEST2D_OPTIMIZER_nlopt)
@@ -51,7 +53,7 @@ target_link_options(libnest2d_js
         "SHELL:-s ERROR_ON_UNDEFINED_SYMBOLS=0"
         "SHELL:--bind"
         "SHELL:-l embind"
-        "SHELL: --embind-emit-tsd libnest2d_js.d.ts"
+        "SHELL: --emit-tsd libnest2d_js.d.ts"
         "SHELL:-sWASM_BIGINT=1"
 )
 

libnest2d_js/libnest2d_js.cpp

@@ -161,12 +161,12 @@ EMSCRIPTEN_BINDINGS(libnest2d_js) {
     // Item class
     class_<Item>("Item")
         .constructor<const PolygonImpl&>()
-        .class_function("createFromVertices", optional_override([](const emscripten::val& jsVertices) -> Item* {
+        .class_function("createFromVertices", optional_override([](const emscripten::val& jsVertices) -> Item {
             std::vector<Point> vertices = jsArrayToPointVector(jsVertices);
             PolygonImpl polygon;
             polygon.Contour = vertices;
-            return new Item(polygon);
-        }), allow_raw_pointers())
+            return Item(polygon);
+        }))
         .function("binId", select_overload<int() const>(&Item::binId))
         .function("setBinId", select_overload<void(int)>(&Item::binId))
         .function("area", &Item::area)
@@ -187,6 +187,7 @@ EMSCRIPTEN_BINDINGS(libnest2d_js) {
             return pointVectorToJSArray(poly.Contour);
         }));
 
+
     // Polygon class for internal type compatibility
     class_<Polygon>("Polygon");