prevent pal overwrite image data when sharing same res idx #164

Author: UlyssesWu

FreeMote.Psb/PsbExtension.cs

@@ -807,6 +807,7 @@ public static byte[] SaveAsMdf(this PSB psb, uint? key = null)
         /// <returns></returns>
         public static MemoryStream EncodeMdf(Stream stream, string key, int? keyLength, bool keepHeader)
         {
+            Logger.LogHint($"[MDF] key: {key} len: {keyLength}");
             var ms = new MemoryStream((int) stream.Length); //MsManager.GetStream("EncodeMdf", (int)stream.Length);
             EncodeMdf(stream, ms, key, keyLength, keepHeader);
             return ms;

FreeMote.Psb/PsbResHelper.cs

@@ -797,7 +797,7 @@ public static ImageMetadata GenerateImageMetadata(PsbDictionary d, PsbResource r
             PsbString palTypeString = null;
             if (d["pal"] is PsbResource palRes)
             {
-                if (duplicatePalette)
+                if (duplicatePalette || (palRes != null && palRes == r)) //prevent pal overwrite resource
                 {
                     palResource = new PsbResource(palRes.Index);
                     d["pal"] = palResource;

FreeMote.Psb/Resources/ImageMetadata.cs

@@ -144,6 +144,14 @@ public byte[] PalData
 
             internal set
             {
+                if (Palette != null && ReferenceEquals(Palette, Resource))
+                {
+                    // Palette and image data must not share the same backing resource when writing.
+                    // Otherwise assigning PalData would overwrite Data.
+                    Logger.LogWarn("[WARN] Palette and image data must not share the same backing resource when writing.");
+                    Palette = new PsbResource();
+                }
+
                 Palette ??= new PsbResource();
 
                 Palette.Data = value;