Skip to content

Commit 5aa5a26

Browse files
committed
Get menu tests working again by shortening the press duration
1 parent 21cc126 commit 5aa5a26

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

XitUITests/ReadOnlyUITests.swift

+1-2
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ class ReadOnlyUITests: XCTestCase
222222
file: StaticString = #file, line: UInt = #line)
223223
{
224224
XCTContext.runActivity(named: context) { _ in
225-
button.press(forDuration: 0.5)
225+
button.press(forDuration: 0.25)
226226

227227
XCTAssertTrue(menu.isHittable)
228228
XCTAssertEqual(menu.menuItems.count, itemTitles.count,
@@ -238,7 +238,6 @@ class ReadOnlyUITests: XCTestCase
238238

239239
func testRepoOpMenus() throws
240240
{
241-
throw XCTSkip("pop-up menu tests aren't working")
242241
checkPopup("Fetch menu",
243242
button: Window.fetchButton, menu: Window.fetchMenu, itemTitles: [
244243
"Fetch All Remotes",

XitUITests/UnicodeRepoUITests.swift

+3-6
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ class FetchTests: UnicodeRepoUITests
2424
{
2525
func testFetchRemote() throws
2626
{
27-
throw XCTSkip("pop-up menu tests aren't working")
2827
let newFileName = "newfile.txt"
2928

3029
XCTAssert(env.makeRemoteCopy(named: remoteName))
@@ -48,7 +47,7 @@ class FetchTests: UnicodeRepoUITests
4847
// doesn't know yet that it's behind.
4948
XCTAssertFalse(statusIndicator.exists)
5049

51-
Window.fetchButton.press(forDuration: 0.5)
50+
Window.fetchButton.press(forDuration: 0.25)
5251
Window.fetchMenu.menuItems["Fetch Remote \"\(remoteName)\""].click()
5352
wait(for: [hiding(of: Window.progressSpinner)], timeout: 3.0)
5453

@@ -100,8 +99,7 @@ class PushTests: UnicodeRepoUITests
10099

101100
func testPushAnyTracking() throws
102101
{
103-
throw XCTSkip("pop-up menu tests aren't working")
104-
Window.pushButton.press(forDuration: 0.5)
102+
Window.pushButton.press(forDuration: 0.25)
105103
Window.pushMenu.menuItems["Push to Any Tracking Branches on \"\(remoteName)\""].click()
106104

107105
Window.window.sheets.buttons["Push"].click()
@@ -127,14 +125,13 @@ class PushNewTests: UnicodeRepoUITests
127125

128126
func pushNewBranch(tracking: Bool) throws
129127
{
130-
throw XCTSkip("pop-up menu tests aren't working")
131128
env.open()
132129

133130
let indicator = Sidebar.trackingStatusIndicator(branch: branchName)
134131

135132
XCTAssertFalse(indicator.exists)
136133

137-
Window.pushButton.press(forDuration: 0.5)
134+
Window.pushButton.press(forDuration: 0.25)
138135
Window.pushMenu.menuItems["Push to New Remote Branch..."].click()
139136

140137
let trackingButton = PushNewSheet.setTrackingCheck

0 commit comments

Comments
 (0)