Skip to content

Commits not in galaxy, node-exporter fails to start. #30

@pdehlke

Description

@pdehlke

I freely admit that I know nothing of how galaxy works, but:

When I include this role via galaxy, or download it with ansible-galaxy install undergreen.prometheus-node-exporter, what I get in templates/init/prometheus-node-exporter.conf.j2 is:

[ec2-user@ip-172-31-76-131 init]$ cat prometheus-node-exporter.conf.j2
description "Prometheus Node Exporter"
start on (local-filesystems and net-device-up IFACE!=lo)
stop on runlevel [016]

respawn
{% if upstart_version.stdout | replace("init (upstart ", "") |replace(")","") | version_compare('1.4', '>=') %}
setuid {{ prometheus_exporters_common_user }}
setgid {{ prometheus_exporters_common_group }}
{% endif %}

script
exec >> "{{ prometheus_exporters_common_log_dir }}/node-exporter.log"
exec 2>&1
exec {{ prometheus_exporters_common_root_dir }}/node_exporter_current/node_exporter {% for prometheus_node_exporter_collector in prometheus_node_exporter_enabled_collectors %}--collector.{{ prometheus_node_exporter_collector }} {% endfor %} {% for flag, flag_value in prometheus_node_exporter_config_flags.items() %}--{{ flag }}={{ flag_value }} {% endfor %}

end script
[ec2-user@ip-172-31-76-131 init]$

Which says that the version galaxy has does not include commit bc21fe2.

As a result, if i include this role via galaxy, node-exporter does not start on Amazon Linux.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions