fix: shell and filesystem logic to support Windows paths

Author: Undiluted7027

allos/utils/file_utils.py

@@ -29,7 +29,7 @@ def is_safe_path(base_dir: Path, target_path: Path) -> bool:
         resolved_target = target_path.resolve(strict=True)
         # Check if the resolved target path is a subpath of the resolved base path
         return resolved_target.is_relative_to(resolved_base)
-    except (FileNotFoundError, RuntimeError):
+    except (FileNotFoundError, RuntimeError, OSError):
         # strict=True raises FileNotFoundError if path doesn't exist
         # is_relative_to can raise RuntimeError on Windows with different drives
         # In these cases, we can check the unresolved path as a fallback
@@ -154,9 +154,9 @@ def list_directory_recursive(
 
         current_path = Path(root).relative_to(base_dir)
         for name in sorted(dirs):
-            contents.append(f"{current_path / name}/")
+            contents.append(f"{(current_path / name).as_posix()}/")
         for name in sorted(files):
-            contents.append(str(current_path / name))
+            contents.append(str((current_path / name).as_posix()))
     return contents
 
 
@@ -169,5 +169,8 @@ def list_directory_non_recursive(
         if not show_hidden and entry.name.startswith("."):
             continue
         relative_path = entry.relative_to(base_dir)
-        contents.append(f"{relative_path}/" if entry.is_dir() else str(relative_path))
+        if entry.is_dir():
+            contents.append(f"{relative_path.as_posix()}/")
+        else:
+            contents.append(str(relative_path.as_posix()))
     return contents

tests/unit/tools/test_shell_tool.py

@@ -1,6 +1,6 @@
 # tests/unit/tools/test_shell_tool.py
 
-import platform
+import sys
 
 import pytest
 
@@ -35,10 +35,11 @@ def test_execute_command_with_error(self):
 
     def test_execute_timeout(self):
         """Test that a long-running command is correctly timed out."""
-        # Use a command that sleeps for longer than the timeout
-        sleep_command = (
-            "sleep 2" if platform.system() != "Windows" else "timeout /t 2 /nobreak"
-        )
+        # Use a reliable cross-platform way to create a long-running process.
+        # This calls the current Python interpreter to run a short script that sleeps.
+        python_executable = sys.executable
+        sleep_command = f'"{python_executable}" -c "import time; time.sleep(2)"'
+
         result = self.tool.execute(command=sleep_command, timeout=1)
 
         assert result["status"] == "error"