Fix LoadGameOverlay: module name check + robust Steam path + PATH fallback

Author: xinerqu

dllmain.cpp

@@ -502,34 +502,86 @@ static void LoadGameOverlay()
     {
         forcedAppId = g_ForcedAppId;
     }
-    
+
+    // Check if overlay is already loaded by module name (not hardcoded path)
     #if defined(_M_IX86)
-        HMODULE hOverlay = GetModuleHandleW(L"C:\\Program Files (x86)\\Steam\\GameOverlayRenderer.dll");
+        const char* overlayName = "GameOverlayRenderer.dll";
     #elif defined(_M_AMD64)
-        HMODULE hOverlay = GetModuleHandleW(L"C:\\Program Files (x86)\\Steam\\GameOverlayRenderer64.dll");
+        const char* overlayName = "GameOverlayRenderer64.dll";
     #endif
+    HMODULE hOverlay = GetModuleHandleA(overlayName);
 
     if (forcedAppId != 769 && !hOverlay)
     {
-        const char* installPath = SteamAPI_GetSteamInstallPath();
-        if (_stricmp(installPath, "UCOnline2_InvalidPath") != 0)
+        // Use the same path resolution logic as InitSteamClient
+        char steamPath[MAX_PATH] = {0};
+        bool found = false;
+
+        if (GetSteamPathFromRegistry(steamPath, MAX_PATH))
+        {
+            found = true;
+        }
+        else
+        {
+            const char* commonPaths[] = {
+                "C:\\Program Files (x86)\\Steam",
+                "C:\\Steam"
+            };
+            for (int i = 0; i < _countof(commonPaths); i++)
+            {
+                DWORD attrs = GetFileAttributesA(commonPaths[i]);
+                if (attrs != INVALID_FILE_ATTRIBUTES && (attrs & FILE_ATTRIBUTE_DIRECTORY))
+                {
+                    strcpy_s(steamPath, MAX_PATH, commonPaths[i]);
+                    found = true;
+                    break;
+                }
+            }
+            if (!found)
+            {
+                const char* cachedPath = SteamAPI_GetSteamInstallPath();
+                if (cachedPath && strcmp(cachedPath, "UCOnline2_InvalidPath") != 0)
+                {
+                    strcpy_s(steamPath, MAX_PATH, cachedPath);
+                    found = true;
+                }
+            }
+        }
+
+        if (found)
         {
             char overlayPath[MAX_PATH] = { 0 };
-            #if defined(_M_IX86)
-                _snprintf_s(overlayPath, MAX_PATH, _TRUNCATE, "%s\\GameOverlayRenderer.dll", installPath);
-            #elif defined(_M_AMD64)
-                _snprintf_s(overlayPath, MAX_PATH, _TRUNCATE, "%s\\GameOverlayRenderer64.dll", installPath);
-            #endif
+            _snprintf_s(overlayPath, MAX_PATH, _TRUNCATE, "%s\\%s", steamPath, overlayName);
+
+            UCOLOG("[UCOnline2] Loading game overlay from: %s", overlayPath);
             HMODULE hLoaded = LoadLibraryExA(overlayPath, nullptr, LOAD_WITH_ALTERED_SEARCH_PATH);
             if (hLoaded)
             {
                 UCOLOG("[UCOnline2] Loaded game overlay: %s", overlayPath);
             }
             else
             {
-                UCOLOG("[UCOnline2] Failed to load game overlay: %s (error %lu)", overlayPath, GetLastError());
+                UCOLOG("[UCOnline2] Failed to load game overlay from Steam dir (error %lu), trying PATH...", GetLastError());
+                // Fallback: let Windows search PATH
+                hLoaded = LoadLibraryExA(overlayName, nullptr, LOAD_WITH_ALTERED_SEARCH_PATH);
+                if (hLoaded)
+                {
+                    UCOLOG("[UCOnline2] Loaded game overlay from PATH");
+                }
+                else
+                {
+                    UCOLOG("[UCOnline2] Failed to load game overlay: %s (error %lu)", overlayName, GetLastError());
+                }
             }
         }
+        else
+        {
+            UCOLOG("[UCOnline2] Could not determine Steam path, skipping overlay load");
+        }
+    }
+    else if (hOverlay)
+    {
+        UCOLOG("[UCOnline2] Game overlay already loaded, skipping");
     }
 #endif
 }