Switch AUTO_INIT_CLASS to global constant

Author: nateabele

MIGRATING.md

@@ -109,10 +109,10 @@ class MyClass {
 
 ### Defering class initialization
 
-Prior to 2.0, class initialization (auto-dispatching to the `_init()` method) could be suppressed by passing `'init' => false` to the constructor. This has been replaced with a constant that is mixed in from the trait, and can be accessed by the class name, i.e.:
+Prior to 2.0, class initialization (auto-dispatching to the `_init()` method) could be suppressed by passing `'init' => false` to the constructor. This has been replaced with a global constant that is defined in the `AutoConfigurable` trait:
 
 ```php
-new MyClass([MyClass::AUTO_INIT_CLASS => false])
+new MyClass([AUTO_INIT_CLASS => false])
 ```
 
 Finally, as a result of this change, the `'init'` key is no longer automatically merged into the `$_config` property. Tests or other application logic depending on this behavior should be changed.

core/AutoConfigurable.php

@@ -9,13 +9,13 @@
 
 namespace lithium\core;
 
+define('AUTO_INIT_CLASS', 'AUTO_INIT_CLASS');
+
 /**
  * Provides methods to configure an object.
  */
 trait AutoConfigurable {
 
-	public const AUTO_INIT_CLASS = 'lithium\core\AutoConfigurable::AUTO_INIT_CLASS';
-
 	/**
 	 * Stores configuration information for object instances at time of construction.
 	 *
@@ -84,7 +84,7 @@ protected function _autoConfig(array $config, array $auto) {
 	}
 
 	protected function _autoInit($config) {
-		if (!isset($config[static::AUTO_INIT_CLASS]) || $config[static::AUTO_INIT_CLASS] !== false) {
+		if (!isset($config[AUTO_INIT_CLASS]) || $config[AUTO_INIT_CLASS] !== false) {
 			$this->_init();
 		}
 	}

tests/cases/action/ResponseTest.php

@@ -17,7 +17,7 @@ class ResponseTest extends \lithium\test\Unit {
 	public $response = null;
 
 	public function setUp() {
-		$this->response = new MockResponse([MockResponse::AUTO_INIT_CLASS => false]);
+		$this->response = new MockResponse([AUTO_INIT_CLASS => false]);
 	}
 
 	public function testTypeManipulation() {

tests/cases/net/http/ServiceTest.php

@@ -29,7 +29,7 @@ public function setUp() {
 	}
 
 	public function testAllMethodsNoConnection() {
-		$http = new Service([Service::AUTO_INIT_CLASS => false]);
+		$http = new Service([AUTO_INIT_CLASS => false]);
 		$this->assertEmpty($http->get());
 		$this->assertEmpty($http->post());
 		$this->assertEmpty($http->put());

tests/integration/data/source/database/adapter/MySqlTest.php

@@ -65,7 +65,7 @@ public function testEnabledFeatures() {
 	 * Tests that the object is initialized with the correct default values.
 	 */
 	public function testConstructorDefaults() {
-		$db = new MockMySql(['autoConnect' => false, MockMySql::AUTO_INIT_CLASS => false]);
+		$db = new MockMySql(['autoConnect' => false, AUTO_INIT_CLASS => false]);
 		$result = $db->get('_config');
 		$expected = [
 			'autoConnect' => false, 'encoding' => null,'persistent' => true,

tests/integration/data/source/database/adapter/PostgreSqlTest.php

@@ -65,7 +65,7 @@ public function testEnabledFeatures() {
 	 * Tests that the object is initialized with the correct default values.
 	 */
 	public function testConstructorDefaults() {
-		$db = new MockPostgreSql(['autoConnect' => false, MockPostgreSql::AUTO_INIT_CLASS =>  false]);
+		$db = new MockPostgreSql(['autoConnect' => false, AUTO_INIT_CLASS =>  false]);
 		$result = $db->get('_config');
 		$expected = [
 			'autoConnect' => false,

tests/integration/data/source/database/adapter/Sqlite3Test.php

@@ -67,7 +67,7 @@ public function testEnabledFeatures() {
 	 * Tests that the object is initialized with the correct default values.
 	 */
 	public function testConstructorDefaults() {
-		$db = new MockSqlite3(['autoConnect' => false, MockSqlite3::AUTO_INIT_CLASS => false]);
+		$db = new MockSqlite3(['autoConnect' => false, AUTO_INIT_CLASS => false]);
 		$result = $db->get('_config');
 		$expected = [
 			'autoConnect' => false,