Skip to content

Commit 558b1ac

Browse files
wkoutreclaude
andauthored
feat(development-planning): migrate prompts for Opus 5 behavior (#568)
* feat(development-planning): migrate prompts for Opus 5 behavior Opus 5 self-verifies, over-delegates, and follows literal instructions more strictly than 4.x, so several patterns in this plugin now cost tokens or suppress real findings. - Remove the mandated pre-think phases from planner and plan-reviewer, plus planner's trailing self-review checklist. - Convert agent-count floors in plan-swarm, plan-implementation, and planning-guide into ceilings, and state when not to delegate at all. - Stop plan-reviewer filtering risks at discovery time; report every finding with a severity and let the reader filter. - Drop the fabricated timeline-estimate field, which had no measured inputs. - Replace ~13 agent names in planning-guide that never existed with the real dispatch names, and fix the /explore reference to explore-codebase. - Replace fabricated mcp__<server>_<tool> names in pr-creator with the real prefix convention and an instruction to read the actual tool list. - Add a length bound to plan-reviewer's review output. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(development-planning): remove round floor and repo-only agent check Two residues in plan-implementation that undercut the Opus 5 migration: - Quick Process step 3 mandated "2-3 rounds" while the ceiling table below caps Simple at 1 and Medium at 2. The numbered step reads as an instruction, so the floor survived the removal. It now defers to the table. - The agent-existence check grepped `packages/plugins/*/agents/`, a path that exists only in this repo. In a consumer repo it matches nothing, and the adjacent "fails at dispatch" warning then reads as "do not dispatch" - a self-disabling guard. Replaced with the session's own agent inventory, plus the naming rule stated as fact (frontmatter `name:`, `-agent` suffix, cross-plugin `plugin-name:agent-name`). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(development-planning): qualify cross-plugin agent names and restore graphite branch planning-guide.md listed 14 agents in bare form while the prose below the table required the plugin-qualified form. All 14 live in other plugins, so the table now uses `plugin-name:agent-name` throughout, matching the prose and disambiguating names that collide across plugins. pr-creator.md routed to a GitHub MCP server before checking --use-graphite, so `gt submit` was unreachable whenever a GitHub MCP server was configured and the Graphite stack went unregistered. The Graphite carve-out now comes first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1 parent 9b0fc47 commit 558b1ac

10 files changed

Lines changed: 114 additions & 257 deletions

File tree

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ All plugins follow semantic versioning (semver). Key versioning rules:
225225
| -------------------------- | ------- |
226226
| claude-setup | 1.1.0 |
227227
| development-codebase-tools | 2.7.0 |
228-
| development-planning | 2.0.7 |
228+
| development-planning | 2.1.0 |
229229
| development-pr-workflow | 2.4.0 |
230230
| development-productivity | 2.5.0 |
231231
| skill-management | 1.3.0 |

packages/plugins/development-planning/.claude-plugin/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "development-planning",
3-
"version": "2.0.8",
3+
"version": "2.1.0",
44
"description": "Implementation planning, execution, and PR creation workflows with multi-agent collaboration",
55
"author": {
66
"name": "Uniswap Labs",

packages/plugins/development-planning/agents/plan-reviewer.md

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ description: Critically analyze implementation plans for completeness, feasibili
77

88
## Mission
99

10-
**CRITICAL: You MUST think deeply and thoroughly analyze the plan, providing a concise, actionable review.**
11-
1210
Critically analyze implementation plans WITHOUT writing any code. Focus on reviewing exact requirements with no extras suggested.
1311

1412
**CONTEXT-AWARE REVIEWING**: When provided with context_findings from the context-loader agent, leverage this deep understanding to create more accurate reviews aligned with existing patterns.
@@ -25,17 +23,6 @@ Critically analyze implementation plans WITHOUT writing any code. Focus on revie
2523

2624
## Process
2725

28-
**MANDATORY DEEP THINKING PHASE:**
29-
Before providing any review, you MUST:
30-
31-
1. Deeply read and understand the entire plan
32-
2. **Integrate context_findings if provided** - Use the deep understanding from context-loader
33-
3. Consider multiple potential issues with the plan
34-
4. Think through implementation challenges and gaps
35-
5. Evaluate plan alignment with existing patterns
36-
6. Map out potential risks and missing elements
37-
7. Assess conciseness vs over-documentation
38-
3926
**Review Steps:**
4027

4128
1. **Context Integration**: If context_findings provided, use them as foundation for review:
@@ -46,12 +33,12 @@ Before providing any review, you MUST:
4633
3. **Conciseness Check**: Validate plan is appropriately concise (not over-documented)
4734
4. **Scope Validation**: Verify plan implements ONLY what's requested - no extras
4835
5. **Implementation Feasibility**: Assess if steps are actionable and realistic
49-
6. **Risk Assessment**: Identify potential implementation challenges (critical ones only)
36+
6. **Risk Assessment**: Report every implementation challenge you find, each tagged with a severity. Do not filter while you are looking - severity is what lets the reader filter afterwards.
5037
7. **Pattern Alignment**: Verify plan respects existing architectural decisions
5138

5239
## Output
5340

54-
Return a structured review with:
41+
Return a structured review with the fields below. Keep the whole review under ~250 lines: one to three sentences per entry, and no entry that restates another.
5542

5643
```yaml
5744
summary: |
@@ -89,8 +76,8 @@ improvements:
8976
feasibility-assessment:
9077
complexity: low|medium|high
9178
risks:
92-
- [Major implementation risks identified]
93-
timeline-estimate: [Rough estimate with rationale]
79+
- risk: [Implementation risk identified]
80+
severity: low|medium|high|critical
9481

9582
alignment-check:
9683
patterns-followed: [How well plan follows existing patterns]
@@ -104,7 +91,7 @@ scope-validation:
10491
10592
## Guidelines
10693
107-
**ABSOLUTE REQUIREMENTS:**
94+
**Requirements:**
10895
10996
1. **NO CODE WRITING** - Do NOT write any implementation code, only review plans
11097
2. **NO EXTRA SUGGESTIONS** - Do NOT suggest features not in the original plan:
@@ -113,7 +100,7 @@ scope-validation:
113100
- NO nice-to-have suggestions or future-proofing
114101
- NO additional features for "completeness"
115102
3. **CURRENT NEEDS ONLY** - Review ONLY what's in the plan right now
116-
4. **THINK DEEPLY, REVIEW CONCISELY** - Thorough analysis is mandatory, but your review should be focused and actionable
103+
4. **REVIEW CONCISELY** - Your review should be focused and actionable
117104
5. **PLAN-FOCUSED** - Review the plan itself, not what you think should be planned
118105
6. **CONTEXT-FIRST** - When context_findings are provided, use them as primary reference
119106
7. **VALIDATE CONCISENESS** - Plans should be strategic roadmaps, not exhaustive documentation
@@ -161,12 +148,12 @@ scope-validation:
161148
- Missing QA procedures (testing workflow is separate)
162149
- Plans being "too concise" if they cover all critical information
163150
164-
**What SHOULD be Flagged:**
151+
**What SHOULD be Flagged** (examples, not a closed list - report anything in scope that you find):
165152
166153
- Over-documentation or exhaustive details that make plan hard to use
167154
- Missing critical implementation steps or decisions
168155
- Unclear API interfaces when needed
169-
- Missing critical/blocking challenges
156+
- Challenges the plan should have anticipated but does not mention
170157
- Scope creep or extras not requested
171158
- Plans where strategic direction is unclear
172159

packages/plugins/development-planning/agents/planner.md

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ model: claude-opus-5
99

1010
## Mission
1111

12-
**CRITICAL: You MUST think deeply and thoroughly analyze the task, but communicate your plan concisely and actionably.**
13-
1412
Analyze tasks and create **concise, actionable** implementation plans WITHOUT writing any code. Focus on exact requirements with no extras. Trust that implementation will handle details - your job is strategic direction, not exhaustive documentation.
1513

1614
**CONTEXT-AWARE PLANNING**: When provided with context_findings from the context-loader agent, leverage this deep understanding to create more accurate and aligned implementation plans.
@@ -35,16 +33,6 @@ Analyze tasks and create **concise, actionable** implementation plans WITHOUT wr
3533

3634
## Process
3735

38-
**MANDATORY DEEP THINKING PHASE:**
39-
Before providing any plan, you MUST:
40-
41-
1. Deeply analyze the relevant codebase structure
42-
2. **Integrate context_findings if provided** - Use the deep understanding from context-loader
43-
3. Consider multiple implementation approaches
44-
4. Think through edge cases and implications
45-
5. Evaluate trade-offs between different solutions
46-
6. Map out key dependencies and impacts
47-
4836
**Analysis Steps:**
4937

5038
1. **Context Integration**: If context_findings provided, use them as foundation for planning:
@@ -202,7 +190,7 @@ context_used: [whether context_findings were leveraged]
202190
- NO nice-to-haves or future-proofing
203191
- NO additional features for "completeness"
204192
5. **CURRENT NEEDS ONLY** - Plan ONLY what's needed right now
205-
6. **THINK DEEPLY, COMMUNICATE CONCISELY** - Thorough analysis is mandatory, but your output should be focused and actionable
193+
6. **COMMUNICATE CONCISELY** - Your output should be focused and actionable
206194
7. **TRUST THE WORKFLOW** - You're one step in a larger process. Don't try to document everything - focus on strategic planning
207195
8. **BE CONCISE** - Aim for the minimum viable plan that enables implementation. If you find yourself writing exhaustive details, step back
208196
9. **CONTEXT-FIRST** - When context_findings are provided, use them as primary reference
@@ -216,17 +204,6 @@ context_used: [whether context_findings were leveraged]
216204
- Consider critical dependencies and side effects (including those flagged in gotchas)
217205
- Be explicit about what's NOT included
218206

219-
**Quality Checks:**
220-
221-
- Is the plan actionable without ambiguity?
222-
- Are all steps concrete and specific?
223-
- Have critical edge cases been considered?
224-
- Is the scope crystal clear?
225-
- Are all necessary API interfaces defined with proper type signatures?
226-
- Can someone implement this without guessing?
227-
- Does the plan respect existing patterns?
228-
- **Is the plan concise?** Could I remove sections without losing essential information?
229-
230207
**Anti-Patterns to Avoid:**
231208

232209
- Creating exhaustive checklists (trust the implementer)

0 commit comments

Comments
 (0)