Skip to content

Commit 8324cd8

Browse files
wkoutreclaude
andcommitted
fix(development-pr-workflow): correct Linear MCP tool name, drop git add -A, bump to 2.4.0
Opus 5 migration, remaining broken references plus the mandatory version bump: - start-linear-task, linear-task-and-pr-from-changes: `mcp__linear__create_issue` does not exist. Verified against the live Linear MCP tool list: the real name is `save_issue`. `get_user`, `get_issue`, `list_teams`, `list_projects` and `list_issue_labels` alongside it are all real and left alone - linear-task-and-pr-from-changes: `git add -A` replaced with explicit per-file staging, with the reason inline so it does not get reverted - start-linear-task: the `--skip-graphite` example flag is not in the command's own argument table; corrected to `--use-graphite false` - update-graphite-stack: two references to a `pr-issue-resolver` skill that does not exist (the skill is `resolve-pr-issues`); removed the optional refactorer-agent "verify changes maintain quality" follow-up pass - pr-guide: concurrency cap on the inline-comment path, matching SKILL.md - both Linear commands: decorative CRITICAL/ALL-CAPS emphasis softened, wording otherwise unchanged - plugin.json 2.3.0 -> 2.4.0 and the matching root CLAUDE.md row. Both read 2.3.0 before this change, so they were already in agreement Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 92ec989 commit 8324cd8

6 files changed

Lines changed: 20 additions & 19 deletions

File tree

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ All plugins follow semantic versioning (semver). Key versioning rules:
226226
| claude-setup | 1.0.5 |
227227
| development-codebase-tools | 2.6.2 |
228228
| development-planning | 2.0.7 |
229-
| development-pr-workflow | 2.3.0 |
229+
| development-pr-workflow | 2.4.0 |
230230
| development-productivity | 2.4.1 |
231231
| skill-management | 1.2.0 |
232232
| spec-workflow | 2.0.1 |

packages/plugins/development-pr-workflow/.claude-plugin/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "development-pr-workflow",
3-
"version": "2.3.0",
3+
"version": "2.4.0",
44
"description": "Pull request review, issue resolution, and Graphite stack management",
55
"author": {
66
"name": "Uniswap Labs",

packages/plugins/development-pr-workflow/commands/linear-task-and-pr-from-changes.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
description: Take local changes, create a Linear task, create a branch (optionally in a worktree), commit, and publish a PR
33
argument-hint: [--team <id>] [--trunk <branch>] [--create-worktree] [--use-graphite true/false]
4-
allowed-tools: Bash(*), Read(*), Write(*), AskUserQuestion(*), mcp__graphite__run_gt_cmd(*), mcp__github__create_pull_request(*), mcp__linear__create_issue(*), mcp__linear__get_user(*), mcp__linear__list_teams(*), mcp__linear__list_projects(*), mcp__linear__list_issue_labels(*)
4+
allowed-tools: Bash(*), Read(*), Write(*), AskUserQuestion(*), mcp__graphite__run_gt_cmd(*), mcp__github__create_pull_request(*), mcp__linear__save_issue(*), mcp__linear__get_user(*), mcp__linear__list_teams(*), mcp__linear__list_projects(*), mcp__linear__list_issue_labels(*)
55
---
66

77
# Changes to PR Workflow
@@ -123,7 +123,7 @@ As a [user type], I want [goal/capability] so that [benefit/value].
123123

124124
### Phase 1: Fetch Linear User and Teams (REQUIRED)
125125

126-
**CRITICAL: Before presenting ANY prompts, you MUST fetch the Linear user to get the username for branch prefix options.**
126+
**Fetch the Linear user before presenting any prompts**the username supplies the branch-prefix options.
127127

128128
```
129129
# Get current Linear user (for assignee and username prefix)
@@ -150,7 +150,7 @@ Follow the shared configuration collection instructions in `@../shared/linear-ta
150150
- `TRUNK_BRANCH` from `--trunk` (if provided)
151151
- `DUE_DATE` from `--due-date` (if provided)
152152

153-
**IMPORTANT: When prompting for branch prefix, the first option MUST be the user's personal namespace:**
153+
**When prompting for branch prefix, the first option is the user's personal namespace:**
154154

155155
```
156156
Branch Prefix options:
@@ -185,7 +185,7 @@ Include these additional questions in the Phase 1 prompt from the shared config:
185185
Use the Linear MCP to create the task with the **auto-generated user story description** from Step 1.5:
186186

187187
```
188-
mcp__linear__create_issue with:
188+
mcp__linear__save_issue with:
189189
- team: <selected team>
190190
- title: <task title - auto-generated or user-provided>
191191
- description: <AUTO-GENERATED user story from Step 1.5>
@@ -303,9 +303,14 @@ Resolves: <LINEAR-ISSUE-ID>
303303

304304
## Step 6: Commit Changes
305305

306+
Stage the files this task actually changed, named individually. Never `git add -A` or
307+
`git add .` — a blanket stage sweeps in untracked secrets, local scratch files, and
308+
unrelated in-progress work, and it is not obvious from the commit that it happened.
309+
306310
```bash
307311
cd "$WORKING_DIR"
308-
git add -A
312+
git status --short # confirm what is present before staging
313+
git add path/to/file-one path/to/file-two
309314
SKIP_CLAUDE=1 git commit -m "<generated commit message>"
310315
```
311316

packages/plugins/development-pr-workflow/commands/start-linear-task.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
description: Start working on a new Linear task by creating a worktree environment. Either provide an existing Linear ticket ID or describe the work to create a new task.
33
argument-hint: [<ticket-id> | --prompt "<description>"] [--team <id>] [--trunk <branch>] [--use-graphite true/false] [--start-working] [--start-prompt "<prompt>"]
4-
allowed-tools: Bash(*), Read(*), Write(*), AskUserQuestion(*), mcp__graphite__run_gt_cmd(*), mcp__github__create_pull_request(*), mcp__linear__create_issue(*), mcp__linear__get_issue(*), mcp__linear__get_user(*), mcp__linear__list_teams(*), mcp__linear__list_projects(*), mcp__linear__list_issue_labels(*)
4+
allowed-tools: Bash(*), Read(*), Write(*), AskUserQuestion(*), mcp__graphite__run_gt_cmd(*), mcp__github__create_pull_request(*), mcp__linear__save_issue(*), mcp__linear__get_issue(*), mcp__linear__get_user(*), mcp__linear__list_teams(*), mcp__linear__list_projects(*), mcp__linear__list_issue_labels(*)
55
---
66

77
# Start Linear Task Workflow
@@ -90,7 +90,7 @@ AskUserQuestion:
9090

9191
### Phase 2: Fetch Linear User and Teams (REQUIRED)
9292

93-
**CRITICAL: Before presenting ANY prompts, you MUST fetch the Linear user to get the username for branch prefix options.**
93+
**Fetch the Linear user before presenting any prompts**the username supplies the branch-prefix options.
9494

9595
```
9696
# Get current Linear user (for assignee and username prefix)
@@ -118,7 +118,7 @@ Follow the shared configuration collection instructions in `@../shared/linear-ta
118118
- `WORKTREE_BASE` from `--worktree_base` (if provided)
119119
- `DUE_DATE` from `--due-date` (if provided)
120120

121-
**IMPORTANT: When prompting for branch prefix, the first option MUST be the user's personal namespace:**
121+
**When prompting for branch prefix, the first option is the user's personal namespace:**
122122

123123
```
124124
Branch Prefix options:
@@ -187,7 +187,7 @@ As a [user type], I want [goal/capability] so that [benefit/value].
187187
**Create the task:**
188188

189189
```
190-
mcp__linear__create_issue with:
190+
mcp__linear__save_issue with:
191191
- team: TEAM
192192
- title: <generated from PROMPT or user-provided>
193193
- description: <generated user story>
@@ -403,7 +403,7 @@ Or with Graphite (if USE_GRAPHITE was enabled):
403403
### With full configuration
404404

405405
```
406-
/start-linear-task DEV-456 --trunk develop --branch-prefix feature --skip-graphite
406+
/start-linear-task DEV-456 --trunk develop --branch-prefix feature --use-graphite false
407407
```
408408

409409
### Interactive mode (no arguments)

packages/plugins/development-pr-workflow/skills/resolve-pr-issues/pr-guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ Use the inline comment as the canonical item (it has file/line context). Discard
201201

202202
| Item Type | Agent | Notes |
203203
| -------------------------------------- | ------------------------------------------------ | -------------------------------------------------------------------- |
204-
| Inline comments (grouped by file) | `development-pr-workflow:comment-resolver-agent` | One agent per file group |
204+
| Inline comments (grouped by file) | `development-pr-workflow:comment-resolver-agent` | One agent per file group; cap at 3 concurrent agents |
205205
| Review body items (with file location) | `development-pr-workflow:comment-resolver-agent` | Grouped with that file's inline comments |
206206
| Review body items (no file location) | `development-pr-workflow:comment-resolver-agent` | Batch up to 3 items per agent; receives full PR diff |
207207
| CI failures (specific file) | `development-pr-workflow:comment-resolver-agent` | Include CI logs in prompt |

packages/plugins/development-pr-workflow/skills/update-graphite-stack/SKILL.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ model: opus
88

99
Automate Graphite PR stack updates by resolving comments and syncing PRs.
1010

11-
> **Note:** This skill requires Graphite CLI (`gt`) as PR stacking is a Graphite-specific concept. For standard Git workflows, use the `pr-issue-resolver` skill to address PR comments on individual PRs.
11+
> **Note:** This skill requires Graphite CLI (`gt`) as PR stacking is a Graphite-specific concept. For standard Git workflows, use the `resolve-pr-issues` skill to address PR comments on individual PRs.
1212
1313
## When to Activate
1414

@@ -24,7 +24,7 @@ Automate Graphite PR stack updates by resolving comments and syncing PRs.
2424
- **Repository initialized** with Graphite: `gt repo init`
2525
- **Existing Graphite stack** with PRs to update
2626

27-
> **Why Graphite-only?** This skill manages PR stacks, which is a Graphite-specific workflow. For standard Git workflows, use `pr-issue-resolver` to address comments on individual PRs.
27+
> **Why Graphite-only?** This skill manages PR stacks, which is a Graphite-specific workflow. For standard Git workflows, use `resolve-pr-issues` to address comments on individual PRs.
2828
2929
## What It Does
3030

@@ -68,10 +68,6 @@ Progress summary with:
6868
- Remaining unresolved items
6969
- Stack synchronization status
7070

71-
## Optional Follow-up
72-
73-
After updates, can invoke **refactorer-agent** to verify changes maintain quality.
74-
7571
## Examples
7672

7773
```

0 commit comments

Comments
 (0)