Skip to content

Allow deadline to be omitted #2924

Open
@NoahZinsmeister

Description

@NoahZinsmeister

After full router-sdk support lands, deadline will be an optional parameter for swaps. In cases when it is omitted, resulting transactions can be anywhere from 1-5k gas cheaper, because of the calldata reduction associated with not passing it. So, we should consider omitting this parameter for specific swaps to save gas. The biggest (5k) savings are when the transaction would otherwise be able to bypass multicall, but beacuse of deadline has to use more expensive encoding, so possibly we could limit this feature to that case.

This is related to #2141, however the goal of that change would be to reduce transaction failures in cases when failure due to deadline is not desired.

Metadata

Metadata

Assignees

No one assigned

    Labels

    improvementImproves the uxp1Great to have, implement first thing after p0s

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions