Add setCallerSafe functions

Author: zhongeric

snapshots/ERC7914Test.json

@@ -1,5 +1,5 @@
 {
   "approveNative": "45972",
   "approveNativeTransient": "24024",
-  "transferFromNative": "31978"
+  "transferFromNative": "32000"
 }

snapshots/MinimalDelegation4337Test.json

@@ -1,4 +1,4 @@
 {
-  "hanldeOps_BATCHED_CALL_singleCall_P256": "209177",
-  "hanldeOps_BATCHED_CALL_singleCall_eoaSigner": "184203"
+  "hanldeOps_BATCHED_CALL_singleCall_P256": "209199",
+  "hanldeOps_BATCHED_CALL_singleCall_eoaSigner": "184225"
 }

snapshots/MinimalDelegationExecuteTest.json

@@ -1,13 +1,13 @@
 {
-  "execute_BATCHED_CALL_SUPPORTS_OPDATA_singleCall": "92976",
-  "execute_BATCHED_CALL_SUPPORTS_OPDATA_twoCalls": "129584",
-  "execute_BATCHED_CALL_opData_P256_singleCall": "118288",
-  "execute_BATCHED_CALL_opData_singleCall": "92976",
-  "execute_BATCHED_CALL_opData_singleCall_native": "93806",
-  "execute_BATCHED_CALL_opData_twoCalls": "129584",
-  "execute_BATCHED_CALL_singleCall": "59622",
-  "execute_BATCHED_CALL_singleCall_native": "59701",
-  "execute_BATCHED_CALL_twoCalls": "95416",
-  "execute_invalidMode_reverts": "23019",
-  "multicall": "178542"
+  "execute_BATCHED_CALL_SUPPORTS_OPDATA_singleCall": "92998",
+  "execute_BATCHED_CALL_SUPPORTS_OPDATA_twoCalls": "129606",
+  "execute_BATCHED_CALL_opData_P256_singleCall": "118310",
+  "execute_BATCHED_CALL_opData_singleCall": "92998",
+  "execute_BATCHED_CALL_opData_singleCall_native": "93828",
+  "execute_BATCHED_CALL_opData_twoCalls": "129606",
+  "execute_BATCHED_CALL_singleCall": "59644",
+  "execute_BATCHED_CALL_singleCall_native": "59723",
+  "execute_BATCHED_CALL_twoCalls": "95438",
+  "execute_invalidMode_reverts": "23041",
+  "multicall": "178608"
 }

snapshots/MinimalDelegationTest.json

@@ -1,7 +1,7 @@
 {
-  "minimalDelegationEntry bytecode size": "20885",
+  "minimalDelegationEntry bytecode size": "20997",
   "register": "184758",
-  "revoke": "54560",
+  "revoke": "54578",
   "validateUserOp_missingAccountFunds": "64567",
   "validateUserOp_no_missingAccountFunds": "33929"
 }

snapshots/NonceManagerTest.json

@@ -1,3 +1,3 @@
 {
-  "invalidateNonce": "45378"
+  "invalidateNonce": "45400"
 }

src/ERC1271.sol

@@ -16,7 +16,7 @@ abstract contract ERC1271 is IERC1271, BaseAuthorization {
 
     /// @dev Returns whether the caller is considered safe, such
     /// that we don't need to use the nested EIP-712 workflow as defined by ERC-7739
-    function _isSafeERC1271Caller(address caller) internal view virtual returns (bool) {
+    function isSafeERC1271Caller(address caller) public view virtual returns (bool) {
         return _erc1271CallerIsSafe[caller];
     }
 

src/MinimalDelegation.sol

@@ -201,7 +201,7 @@ contract MinimalDelegation is
         // Must be branched because we do abi decoding in memory which will throw since the encoding schemes are different
         // ECDSA signatures are 65 bytes while P256 signatures are 64 bytes
         if (signature.length == 64 || signature.length == 65) {
-            if (_isSafeERC1271Caller(msg.sender)) {
+            if (isSafeERC1271Caller(msg.sender)) {
                 // If the caller is safe we can simply verify the key's signature over `data`
                 // Data is already hashed with the app's domain separator so we don't rehash
                 isValid = key.verify(data, signature);

src/interfaces/IERC1271.sol

@@ -6,6 +6,9 @@ interface IERC1271 {
     /// @notice Sets whether the caller is considered safe to skip the nested EIP-712 workflow
     function setERC1271CallerIsSafe(address caller, bool isSafe) external;
 
+    /// @notice Returns whether the caller is considered safe to skip the nested EIP-712 workflow
+    function isSafeERC1271Caller(address caller) external view returns (bool);
+
     /// @notice Validates the `signature` against the given `hash`.
     /// @dev Wraps the given `hash` in a EIP-712 compliant struct along with the domain separator to be replay safe. Then validates the signature against it.
     /// @return result `0x1626ba7e` if validation succeeded, else `0xffffffff`.

src/libraries/ERC7739Utils.sol

@@ -19,7 +19,7 @@ library ERC7739Utils {
     /// @param hash The hashed message, calculated offchain
     /// @param domainSeparator This account's domain separator
     /// @return The PersonalSign nested EIP-712 hash of the message
-    function toPersonalSignTypedDataHash(bytes32 hash, bytes32 domainSeparator) internal view returns (bytes32) {
+    function toPersonalSignTypedDataHash(bytes32 hash, bytes32 domainSeparator) internal pure returns (bytes32) {
         return MessageHashUtils.toTypedDataHash(domainSeparator, PersonalSignLib.hash(hash));
     }
 
@@ -36,7 +36,7 @@ library ERC7739Utils {
         bytes32 appSeparator,
         string memory contentsName,
         string memory contentsType
-    ) internal view returns (bytes32) {
+    ) internal pure returns (bytes32) {
         bytes32 typedDataSignHash = TypedDataSignLib.hash(contentsName, contentsType, contentsHash, domainBytes);
         return MessageHashUtils.toTypedDataHash(appSeparator, typedDataSignHash);
     }

test/MinimalDelegation.t.sol

@@ -242,6 +242,19 @@ contract MinimalDelegationTest is DelegationHandler, HookHandler {
         assertEq(address(keySettings.hook()), address(0));
     }
 
+    function test_setERC1271CallerIsSafe() public {
+        address caller = makeAddr("caller");
+        vm.prank(address(signerAccount));
+        signerAccount.setERC1271CallerIsSafe(caller, true);
+        assertEq(signerAccount.isSafeERC1271Caller(caller), true);
+    }
+
+    function test_setERC1271CallerIsSafe_revertsWithUnauthorized() public {
+        address caller = makeAddr("caller");
+        vm.expectRevert(BaseAuthorization.Unauthorized.selector);
+        signerAccount.setERC1271CallerIsSafe(caller, true);
+    }
+
     function test_entryPoint_defaultValue() public view {
         assertEq(signerAccount.ENTRY_POINT(), Constants.ENTRY_POINT_V_0_8);
     }