feat: add example spending limit hook #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Apr 8, 2025
| /// @dev An enumerable set of the periods. | ||
| EnumerableSetLib.Uint8Set periods; | ||
| /// @dev Mapping of `uint8(period)` to `TokenPeriodSpendStorage`. | ||
| mapping(uint256 => TokenPeriodSpendStorage) spends; |
There was a problem hiding this comment.
why is this BY period? How would that work if you have two spend periods for the same token that overlap? You'll have to check both periods states and combine the spends somehow?
There was a problem hiding this comment.
If you have two periods for the same token they all must be true:
- Minute, 10 AND hour, 100
You would loop through all of the periods, increment the spend for each and check none exceed?
There was a problem hiding this comment.
You add the same amount to each tracked period spend
snreynolds
reviewed
Apr 8, 2025
| /// @dev Set the spend limit for a key hash. | ||
| /// Uses msg.sender to compute the accountKeyHash. | ||
| function setSpendLimit(bytes32 keyHash, address token, SpendPeriod period, uint256 limit) external { | ||
| AccountKeyHash accountKeyHash = keyHash.wrap(msg.sender); |
There was a problem hiding this comment.
maybe use a different word? wrap is keyword for a custom type
There was a problem hiding this comment.
ok! I did hashSender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.