feat: add example spending limit hook #102
Conversation
| /// @dev An enumerable set of the periods. | ||
| EnumerableSetLib.Uint8Set periods; | ||
| /// @dev Mapping of `uint8(period)` to `TokenPeriodSpendStorage`. | ||
| mapping(uint256 => TokenPeriodSpendStorage) spends; |
There was a problem hiding this comment.
why is this BY period? How would that work if you have two spend periods for the same token that overlap? You'll have to check both periods states and combine the spends somehow?
There was a problem hiding this comment.
If you have two periods for the same token they all must be true:
- Minute, 10 AND hour, 100
You would loop through all of the periods, increment the spend for each and check none exceed?
There was a problem hiding this comment.
You add the same amount to each tracked period spend
| /// @dev Set the spend limit for a key hash. | ||
| /// Uses msg.sender to compute the accountKeyHash. | ||
| function setSpendLimit(bytes32 keyHash, address token, SpendPeriod period, uint256 limit) external { | ||
| AccountKeyHash accountKeyHash = keyHash.wrap(msg.sender); |
There was a problem hiding this comment.
maybe use a different word? wrap is keyword for a custom type
There was a problem hiding this comment.
ok! I did hashSender
| // Collect the ERC20 balances before the batch execution. | ||
| for (uint256 i; i < erc20s.length(); ++i) { | ||
| address token = erc20s.getAddress(i); | ||
| balancesBefore.set(i, SafeTransferLib.balanceOf(token, msg.sender)); |
There was a problem hiding this comment.
this could have duplicates no?
| // to guard, as anyone else can directly submit the calldata and the signature. | ||
| uint32 fnSel = uint32(bytes4(LibBytes.loadCalldata(data, 0x00))); | ||
| // `transfer(address,uint256)`. | ||
| if (fnSel == 0xa9059cbb) { |
There was a problem hiding this comment.
why are we not doing a balance check?
| // where the actual token transfers might not match the calldata amounts. | ||
| // There is no strict definition on what constitutes spending, | ||
| // and we want to be as conservative as possible. | ||
| Math.max( |
There was a problem hiding this comment.
this is just odd to me... what if you like flash loaned something? it would still count it as a spend here even though your balance stayed under some limit this would count it incorrectly no?
|
Closing as we may explore a simpler spending limit example :) |
No description provided.