Revert "feat: env-specific log retention (prod 90d, staging 60d, dev 30d) (#646)" (#659)

This reverts commit 66d0ca8.

Author: codyborn

bin/stacks/api-stack.ts

@@ -9,7 +9,7 @@ import * as aws_logs from 'aws-cdk-lib/aws-logs'
 import * as aws_sns from 'aws-cdk-lib/aws-sns'
 import * as aws_waf from 'aws-cdk-lib/aws-wafv2'
 import { Construct } from 'constructs'
-import { STAGE, logRetentionDays } from '../../lib/util/stage'
+import { STAGE } from '../../lib/util/stage'
 import { SERVICE_NAME } from '../constants'
 import { DashboardStack } from './dashboard-stack'
 import { IndexCapacityConfig, TableCapacityConfig } from './dynamo-stack'
@@ -74,9 +74,7 @@ export class APIStack extends cdk.Stack {
       chatbotSNSArn,
     })
 
-    const accessLogGroup = new aws_logs.LogGroup(this, `${SERVICE_NAME}APIGAccessLogs`, {
-      retention: logRetentionDays(stage as STAGE),
-    })
+    const accessLogGroup = new aws_logs.LogGroup(this, `${SERVICE_NAME}APIGAccessLogs`)
 
     const api = new aws_apigateway.RestApi(this, `${SERVICE_NAME}`, {
       restApiName: `${SERVICE_NAME}`,

bin/stacks/cron-stack.ts

@@ -7,11 +7,9 @@ import { Construct } from 'constructs'
 import path from 'path'
 
 import { SERVICE_NAME, UNIMIND_ALGORITHM_CRON_INTERVAL, FILTER_PATTERNS } from '../constants'
-import { STAGE, logRetentionDays } from '../../lib/util/stage'
 
 export interface CronStackProps extends cdk.NestedStackProps {
   lambdaRole: aws_iam.Role
-  stage: STAGE
   chatbotSNSArn?: string
   envVars?: { [key: string]: string }
 }
@@ -37,7 +35,6 @@ export class CronStack extends cdk.NestedStack {
       environment: {
         NODE_OPTIONS: '--enable-source-maps',
       },
-      logRetention: logRetentionDays(props.stage),
     })
 
     new aws_events.Rule(this, `${SERVICE_NAME}UnimindAlgorithmCron`, {

bin/stacks/lambda-stack.ts

@@ -12,7 +12,7 @@ import { Queue } from 'aws-cdk-lib/aws-sqs'
 import { Construct } from 'constructs'
 import * as path from 'path'
 import { SUPPORTED_CHAINS } from '../../lib/util/chain'
-import { STAGE, logRetentionDays } from '../../lib/util/stage'
+import { STAGE } from '../../lib/util/stage'
 import { SERVICE_NAME, FILTER_PATTERNS } from '../constants'
 import { CronStack } from './cron-stack'
 import { DynamoStack, IndexCapacityConfig, TableCapacityConfig } from './dynamo-stack'
@@ -146,7 +146,6 @@ export class LambdaStack extends cdk.NestedStack {
       },
       environment: getOrdersEnv,
       tracing: aws_lambda.Tracing.ACTIVE,
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.orderNotificationLambda = new aws_lambda_nodejs.NodejsFunction(this, `OrderNotification${lambdaName}`, {
@@ -172,7 +171,6 @@ export class LambdaStack extends cdk.NestedStack {
       vpcSubnets: {
         subnets: [...vpc.privateSubnets],
       },
-      logRetention: logRetentionDays(props.stage),
     })
 
     const notificationConfig = {
@@ -230,7 +228,6 @@ export class LambdaStack extends cdk.NestedStack {
       },
       environment: postOrderEnv,
       tracing: aws_lambda.Tracing.ACTIVE,
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.postLimitOrderLambda = new aws_lambda_nodejs.NodejsFunction(this, `PostLimitOrder${lambdaName}`, {
@@ -248,7 +245,6 @@ export class LambdaStack extends cdk.NestedStack {
       },
       environment: postOrderEnv,
       tracing: aws_lambda.Tracing.ACTIVE,
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.getLimitOrdersLambda = new aws_lambda_nodejs.NodejsFunction(this, `GetLimitOrders${lambdaName}`, {
@@ -263,7 +259,6 @@ export class LambdaStack extends cdk.NestedStack {
         sourceMap: true,
       },
       environment: getOrdersEnv,
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.getNonceLambda = new aws_lambda_nodejs.NodejsFunction(this, `GetNonce${lambdaName}`, {
@@ -285,7 +280,6 @@ export class LambdaStack extends cdk.NestedStack {
         NODE_OPTIONS: '--enable-source-maps',
       },
       tracing: aws_lambda.Tracing.ACTIVE,
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.getDocsLambda = new aws_lambda_nodejs.NodejsFunction(this, `GetDocs${lambdaName}`, {
@@ -305,7 +299,6 @@ export class LambdaStack extends cdk.NestedStack {
         VERSION: '6',
         NODE_OPTIONS: '--enable-source-maps',
       },
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.getDocsUILambda = new aws_lambda_nodejs.NodejsFunction(this, `GetDocsUI${lambdaName}`, {
@@ -325,7 +318,6 @@ export class LambdaStack extends cdk.NestedStack {
         VERSION: '6',
         NODE_OPTIONS: '--enable-source-maps',
       },
-      logRetention: logRetentionDays(props.stage),
     })
 
     this.getUnimindLambda = new aws_lambda_nodejs.NodejsFunction(this, `GetUnimind${lambdaName}`, {
@@ -341,7 +333,6 @@ export class LambdaStack extends cdk.NestedStack {
       },
       environment: postOrderEnv,
       tracing: aws_lambda.Tracing.ACTIVE,
-      logRetention: logRetentionDays(props.stage),
     })
 
     if (props.envVars['POSTED_ORDER_DESTINATION_ARN']) {
@@ -716,7 +707,6 @@ export class LambdaStack extends cdk.NestedStack {
     /* cron stack */
     new CronStack(this, `${SERVICE_NAME}CronStack`, {
       lambdaRole,
-      stage: props.stage,
       envVars: props.envVars,
       chatbotSNSArn: props.chatbotSNSArn,
     })

bin/stacks/step-function-stack.ts

@@ -7,7 +7,7 @@ import { Construct } from 'constructs'
 import path from 'path'
 import { checkDefined } from '../../lib/preconditions/preconditions'
 import { SUPPORTED_CHAINS } from '../../lib/util/chain'
-import { STAGE, logRetentionDays } from '../../lib/util/stage'
+import { STAGE } from '../../lib/util/stage'
 import { SERVICE_NAME, FILTER_PATTERNS } from '../constants'
 import orderStatusTrackingStateMachine from '../definitions/order-tracking-sfn.json'
 
@@ -53,7 +53,6 @@ export class StepFunctionStack extends cdk.NestedStack {
         ...props.envVars,
         stage: stage,
       },
-      logRetention: logRetentionDays(stage),
     })
     this.checkStatusFunction = checkStatusFunction
 

lib/util/stage.ts

@@ -1,18 +1,5 @@
-import { RetentionDays } from 'aws-cdk-lib/aws-logs'
-
 export enum STAGE {
   BETA = 'beta',
   PROD = 'prod',
   LOCAL = 'local',
 }
-
-export function logRetentionDays(stage: STAGE): RetentionDays {
-  switch (stage) {
-    case STAGE.PROD:
-      return RetentionDays.THREE_MONTHS
-    case STAGE.BETA:
-      return RetentionDays.TWO_MONTHS
-    default:
-      return RetentionDays.ONE_MONTH
-  }
-}