Skip to content

Commit ff36bc8

Browse files
codybornclaude
andcommitted
test: use await import instead of require in rpc-headers test
Avoids the @typescript-eslint/no-var-requires lint error flagged in review. Dynamic import + jest.resetModules() re-evaluates the module so the RPC_HEADER_SECRET branch is still exercised per case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 4f69b82 commit ff36bc8

1 file changed

Lines changed: 10 additions & 13 deletions

File tree

test/unit/util/rpc-headers.test.ts

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RPC_HEADERS reads RPC_HEADER_SECRET at module load, so each case sets the env
2-
// and re-imports the module in isolation.
2+
// and re-imports the module after resetting the module registry.
33
describe('RPC_HEADERS', () => {
44
const savedEnv = { ...process.env }
55

@@ -8,26 +8,23 @@ describe('RPC_HEADERS', () => {
88
jest.resetModules()
99
})
1010

11-
const loadHeaders = (): { [key: string]: string } => {
12-
let headers: { [key: string]: string } = {}
13-
jest.isolateModules(() => {
14-
headers = require('../../../lib/util/constants').RPC_HEADERS
15-
})
16-
return headers
11+
const loadHeaders = async (): Promise<{ [key: string]: string }> => {
12+
jest.resetModules()
13+
return (await import('../../../lib/util/constants')).RPC_HEADERS
1714
}
1815

19-
it('always sets the service id header', () => {
16+
it('always sets the service id header', async () => {
2017
delete process.env.RPC_HEADER_SECRET
21-
expect(loadHeaders()['x-uni-service-id']).toEqual('x_order_service')
18+
expect((await loadHeaders())['x-uni-service-id']).toEqual('x_order_service')
2219
})
2320

24-
it('adds the x-internal-service-secret header when RPC_HEADER_SECRET is set', () => {
21+
it('adds the x-internal-service-secret header when RPC_HEADER_SECRET is set', async () => {
2522
process.env.RPC_HEADER_SECRET = 'super-secret-value'
26-
expect(loadHeaders()['x-internal-service-secret']).toEqual('super-secret-value')
23+
expect((await loadHeaders())['x-internal-service-secret']).toEqual('super-secret-value')
2724
})
2825

29-
it('omits the x-internal-service-secret header when RPC_HEADER_SECRET is unset', () => {
26+
it('omits the x-internal-service-secret header when RPC_HEADER_SECRET is unset', async () => {
3027
delete process.env.RPC_HEADER_SECRET
31-
expect(loadHeaders()).not.toHaveProperty('x-internal-service-secret')
28+
expect(await loadHeaders()).not.toHaveProperty('x-internal-service-secret')
3229
})
3330
})

0 commit comments

Comments
 (0)